Adapt Donation LegacyConverters
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

None

Authored By

	gabriel-wmde
	Mar 25 2022, 6:20 PM

Description

Remove all payment-related conversion from the legacy converters and tests.

Add the GetPaymentUseCase as a new dependency to doctrine donation repository, querying the data when writing. There are values in the legacy data that have their own column (outside the data blob)

payment type
payment reference code (formerly known as payment reference), table column ueb_code
donation state (set in updateStatusInformation)

Test with the real implementation of the LegacyDataService to make sure legacy data still gets written.

Related Objects
Search...

Status	Assigned	Task
Open	None	T203684 Improve code and architecture of Fundraising Operation Center
Open	None	T203654 Improve Code and Architecture of Fundraising Frontend
Open	None	T203679 Refactor fundraising database schema
Open	None	T192323 Improve expressiveness of Payment domain and reduce coupling
Resolved	gabriel-wmde	T304726 Use new payment in donation bounded context
Resolved	None	T304728 Adapt Donation LegacyConverters

Event Timeline

gabriel-wmde created this task.Mar 25 2022, 6:20 PM

gabriel-wmde moved this task from Backlog to Ready for estimation on the WMDE-Fundraising-Tech board.Mar 25 2022, 6:31 PM

gabriel-wmde renamed this task from Adapt LegacyConverters to Adapt Donation LegacyConverters.Mar 30 2022, 12:23 PM

gabriel-wmde updated the task description. (Show Details)Mar 30 2022, 1:44 PM

gabriel-wmde set the point value for this task to 5.

gabriel-wmde moved this task from Ready for estimation to Sprint ready on the WMDE-Fundraising-Tech board.Mar 31 2022, 8:00 AM

gabriel-wmde updated the task description. (Show Details)Mar 31 2022, 8:03 AM

gabriel-wmde updated the task description. (Show Details)Mar 31 2022, 9:58 AM

kai.nissen added a project: WMDE-FUN-Sprint-2022-04-19.Apr 20 2022, 9:30 AM

CorinnaHillebrand_WMDE moved this task from Todo to Doing on the WMDE-FUN-Sprint-2022-04-19 board.Apr 22 2022, 11:05 AM

gabriel-wmde updated the task description. (Show Details)Apr 25 2022, 9:41 AM

https://github.com/wmde/fundraising-donations/pull/177
needed a helper field in the payment context:
https://github.com/wmde/fundraising-payments/pull/97

gabriel-wmde added a project: WMDE-FUN-Sprint-2022-05-02.May 2 2022, 9:26 AM

gabriel-wmde moved this task from Todo to Doing on the WMDE-FUN-Sprint-2022-05-02 board.

gabriel-wmde moved this task from Sprint ready to Current Sprint on the WMDE-Fundraising-Tech board.May 2 2022, 9:29 AM

@cohi I merged the payment PR and made all the remaining code changes in a followup PR on your PR: https://github.com/wmde/fundraising-donations/pull/179

The ticket description omitted the fact that this ticket is about fixing the whole storage layer (legacy converters in both directions + doctrine repository) and I'm sorry for that.
My PR should take care of everything.

conny-kawohl_WMDE moved this task from Doing to Review on the WMDE-FUN-Sprint-2022-05-02 board.May 3 2022, 9:03 AM

gabriel-wmde mentioned this in T281853: Remove status from Donation domain model.May 3 2022, 9:37 AM

CorinnaHillebrand_WMDE moved this task from Review to Done on the WMDE-FUN-Sprint-2022-05-02 board.May 5 2022, 2:02 PM

gabriel-wmde added a project: WMDE-FUN-Tech-Payment-Refactoring.May 6 2022, 9:33 AM

CorinnaHillebrand_WMDE moved this task from ToDo to Done on the WMDE-FUN-Tech-Payment-Refactoring board.May 6 2022, 9:36 AM

gabriel-wmde moved this task from Backlog to Sprint Ready on the WMDE-Fundraising-CFR board.May 13 2022, 4:21 PM

kai.nissen closed this task as Resolved.Jun 22 2022, 8:17 AM

kai.nissen claimed this task.

kai.nissen removed kai.nissen as the assignee of this task.Jun 22 2022, 8:19 AM

kai.nissen subscribed.