Page MenuHomePhabricator

FlaggedRevs: Rejecting a null edit that renames a page should also undo the actual rename
Open, LowPublic

Description

Author: thor.malmjursson

Description:
Whilst rejecting a page title move on en.wikinews, it appears that the rejection of the change failed to undo the actual change itself. From speaking to other editors, it appears that a page move makes a log action, and also a null edit so something appears in the history of the page.

The rejection of the page title move appears to have only undone the null edit, and had precisely zero effect on the actual edit I was intending to reject. This is clearly a bug.

Would someone please be able to look into this and try and make some sense of what the heck is going on, since rejecting a pending change to an article should undo whatever that change was, or the function is perfectly useless.


Version: unspecified
Severity: enhancement

Details

Reference
bz28476

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:36 PM
bzimport set Reference to bz28476.
bzimport added a subscriber: Unknown Object (MLST).

Same basic problem as bug 4433.

Further confusing behaviour. When BarkingFish "rejected" the page move, this caused the dummy edit that gets inserted on a page move to actually become sighted (The opposite of expected behaviour). ( https://secure.wikimedia.org/wikinews/en/w/index.php?title=Special:Log&page=38_killed_in_attack_on_Afghan_bank&hide_patrol_log=1&hide_review_log=0 )

My theory for what happened is:
*Diego moved the page, inserting a dummy edit into the page history as normal. Dummy edit is not sighted as normal
*BarkingFish came along and rejected that change.
*Rejecting (From my understanding anyways, could be mistaken) involves making an edit that restores the previous version, and sighting that edit. Since the previous version is exactly the same as the current version (since it's just a dummy edit), MediaWiki considered this new edit as a null edit, and didn't insert it into the db. However it still tried to flag this revert, but instead ended up flagging diego's original move.

End result, it appears as if BarkingFish sighted the very thing he tried to reject, which seems rather wrong.

(In reply to comment #1)

Same basic problem as bug 4433.

"Undo" (which reject is based off) has this nuisance too in addition to "rollback". It's hard to work with dummy revisions like this programmatically, even if we had a "null edit" flag.

(In reply to comment #2)

End result, it appears as if BarkingFish sighted the very thing he tried to
reject, which seems rather wrong.

Dealt with in r88660. Null rollback/undo autoreview was being fired due to the text of the current and attempted revision being the same.

The confusing aspects of this should be fixed (not live though). The main aspect is the ability to reject non-text change aspects. Changing to "enhancement".

Krinkle renamed this task from Rejecting a page move does not undo the change made to the title. to FlaggedRevs: Rejecting a null edit that renames a page should also undo the actual rename.Jan 23 2018, 1:18 AM
Krinkle removed a subscriber: wikibugs-l-list.
Krinkle removed a subscriber: Krinkle.