Page MenuHomePhabricator

Add SpecialPageFatalTest to @group Database
Closed, ResolvedPublic

Description

Adding SpecialPageFatalTest to @group Database would make that test run with SQL strict mode. Currently many special pages (such as those including a pager) make database connections when loaded without parameters, some of which are not compatible with strict mode.

Event Timeline

Change 773915 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/core@master] Add SpecialPageFatalTest to @group Database

https://gerrit.wikimedia.org/r/773915

I understand the problem, not sure about the solution. Adding database group makes those tests much slower (actually it doesn't because all integration tests reset the db regardless of group but the plan is to make it only clean/reset the db when it's in group database.) and the part that worries me is that this might imply that writing to db when opening a special page is okay (it's not, GET requests should not write to db for active/active).

Change 773915 merged by jenkins-bot:

[mediawiki/core@master] Add SpecialPageFatalTest to @group Database

https://gerrit.wikimedia.org/r/773915

No response, closing.