Right now the tab still shows even without JavaScript in the Monobook skin, but doesn't do anything when clicked. This breaks MediaWiki's commitment to unobtrusive JavaScript. Use JavaScript to add tab, so users with it disabled don't have the nonfunctional tab
Description
Description
Event Timeline
Comment Actions
@Naleksuh: Thanks for reporting this. Please use the bug report or feature request form (linked from the top of the task creation page) and fill in the sections in that template. Thanks.
Please also add a more complete description to this task. That should be
- a clear and complete list of exact steps to reproduce the situation, step by step, so that nobody needs to guess or interpret how you performed each step,
- what happens after performing these steps to reproduce,
- what you expected to happen instead,
- a full link to a web address where the issue can be seen (if available),
- the exact MediaWiki version (if it is not on a Wikimedia website) which is shown on Special:Version.
You can edit the task description by clicking . Ideally, a good description should allow any other person to follow these steps (without having to interpret steps) and see the same results. Problems that others can reproduce can get fixed faster. Thanks again!
Comment Actions
@Aklapper That comment has absolutely nothing to do with this task. Did you copy and paste it from somewhere?
Comment Actions
@Naleksuh: If some "tab" doesn't work somewhere, then please provide steps to reproduce. Is something unclear about how to write useful bug reports?
Comment Actions
The steps to reproduce should have been obvious from my original post, but sure:
- Disable JavaScript
- Go to someone else's talk page: https://en.wikipedia.org/wiki/User_talk:Jimbo_Wales
- Click the "wikilove" tab
Comment Actions
Actually, it looks like this only affects Monobook. For Vector users, there is no "wikilove" tab, but instead a heart icon which *does* disappear with JS off.
Comment Actions
Growth-Team was tagged as we are supposed maintainers of WikiLove but in practice it's not an extension that any of us work with or modify. If someone provides a patch, we could try to review, but for now I am moving to triaged.
Comment Actions
That doesn't matter. Not every team or maintainer cares about or uses that "Priority" field
Comment Actions
We already have CSS that should be hiding the tab, not sure why it's not working in MonoBook: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikiLove/+/refs/heads/master/resources/ext.wikiLove.icon.css
Comment Actions
Because the selector at rSMNB resources/screen-desktop.less:242 (at ea7349cfeeb9) gets combined to body.skin--responsive #p-cactions li, which is more specific than the selector in WikiLove (one element selector more) and thus overrides it with display:inline. Changing .client-js to html.client-js would make the two selectors equally specific; I don’t know if that’s enough (if two selectors are equally specific, the loading order counts, and I don’t know which stylesheet is loaded first, or if the loading order is well-defined at all).