Page MenuHomePhabricator

Special:GlobalGroupPermissions should select the current restricting wiki set by default
Closed, ResolvedPublic

Description

Today it happened that a steward accidentally removed the restricting wiki set from the global sysop group: https://meta.wikimedia.org/w/index.php?title=Special:Log&logid=47227549

This happened because the ui sets the restricting wiki set to (none) by default, even if that is not the current situation. If the steward does not notice this, he accidentally removes it without intending to.

Event Timeline

It should already do that, at least there is code for it (here). It feels like this is a regression.

Change 774022 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] Parse wiki set id to string before constructing XmlSelect

https://gerrit.wikimedia.org/r/774022

To be clear, this won't propose to restrict stewards from adding or removing wikis from WikiSets, but rather just retain the current opted in or opted out wikis from the respective WikiSet, correct?

To be clear, this won't propose to restrict stewards from adding or removing wikis from WikiSets, but rather just retain the current opted in or opted out wikis from the respective WikiSet, correct?

Yes, that is the intention

Change 774022 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Cast wiki set id to string before constructing XmlSelect

https://gerrit.wikimedia.org/r/774022

Change 773977 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@REL1_38] Cast wiki set id to string before constructing XmlSelect

https://gerrit.wikimedia.org/r/773977

Change 773978 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@REL1_37] Cast wiki set id to string before constructing XmlSelect

https://gerrit.wikimedia.org/r/773978

Change 773977 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@REL1_38] Cast wiki set id to string before constructing XmlSelect

https://gerrit.wikimedia.org/r/773977

Change 773978 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@REL1_37] Cast wiki set id to string before constructing XmlSelect

https://gerrit.wikimedia.org/r/773978

Zabe claimed this task.