| Esanders | |
| Mar 28 2022, 3:20 PM |
| F35034219: Screenshot 2022-04-01 at 22.49.35.png | |
| Apr 1 2022, 9:50 PM |
| F35027345: image.png | |
| Mar 28 2022, 3:52 PM |
| F35027343: image.png | |
| Mar 28 2022, 3:52 PM |
| F35027314: image.png | |
| Mar 28 2022, 3:20 PM |
| F35027316: image.png | |
| Mar 28 2022, 3:20 PM |
| F35027319: image.png | |
| Mar 28 2022, 3:20 PM |
With your cursor at the bottom of the viewport:
Instead of scrolling the whole page into view (which happens in VE article editing), the inspector height is collapsed
On scrolling down the inspector is still broken:
The same bug is present in StructuredDiscussions/Flow
This is not a very recent regression, being present on a Patch demo from one year ago: https://patchdemo.wmflabs.org/wikis/86f00735362b0061ab7fdef1fd8c8a89/w/index.php/Talk:Main_Page
The problem here is that the desktop context popup is getting clipped (it is an OO.ui.mixin.ClippableElement).
I said this isn't a problem in VE article mode, but there it usually works by accident. While we are calculating clipping, the context is positioned in the top of the surface, which in article mode is usually far away from the bottom of the viewport, so OOUI decides no clipping is necessary:
 |
| paused in debugger while computing clipping |
| note here the selected word is at the bottom of the screen |
It is therefore possible to reproduce this bug in article mode by making the screen very short:
Change 774511 had a related patch set uploaded (by Esanders; author: Esanders):
[VisualEditor/VisualEditor@master] Fix height restriction calculation of desktop context
Growth-Team could review a patch for StructuredDiscussions but otherwise it's not something we can prioritize with the other work we have going on currently.
@kostajh Unless there's something parallel going on inside Flow, I think the fix in VE should cover it as well.
Change 774511 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Follow-up I534ce003d: Fix height restriction calculation of desktop context
Change 769113 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (38b8213b5)
Change 769113 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (38b8213b5)
Flow appears to be fixed by this patch, can be tested here:
https://en.wikipedia.beta.wmflabs.org/wiki/Talk:ESanders_(WMF)/SD
