Page MenuHomePhabricator

StrikerBot doing deprecated action=oathvalidate&totp= queries
Closed, ResolvedPublic

Description

Related to T304375: Remove runtime handling for "legacy" rows and codepaths and specifically https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OATHAuth/+/773918...

It seems StrikerBot (and StrikerTestBot) are doing deprecated queries like action=oathvalidate&totp=foo

These queries should be updated from doing action=oathvalidate&totp=foo to action=oathvalidate&data={"token":"foo"}

Seems this may come from 2 different User-Agents: Striker mwclient/0.10.1 (https://github.com/mwclient/mwclient) and Keystone mwclient/0.10.1 (https://github.com/mwclient/mwclient)

Event Timeline

Change 774401 had a related patch set uploaded (by Reedy; author: Reedy):

[operations/puppet@production] Keystone: Update deprecated action=oathvalidate calls

https://gerrit.wikimedia.org/r/774401

Seems this may come from 2 different User-Agents:

The code is remarkably similar because is was invented for Striker and then copied to Horizon where it replaced a more fragile prior implementation which required shared access to the 'labswiki' database owned by Wikitech (and suffered from replay attack vulnerabilities).

Change 774402 had a related patch set uploaded (by Reedy; author: Reedy):

[labs/striker@master] Update deprecated action=oathvalidate calls

https://gerrit.wikimedia.org/r/774402

Change 774401 merged by Andrew Bogott:

[operations/puppet@production] Keystone: Update deprecated action=oathvalidate calls

https://gerrit.wikimedia.org/r/774401

Change 774402 merged by jenkins-bot:

[labs/striker@master] Update deprecated action=oathvalidate calls

https://gerrit.wikimedia.org/r/774402

bd808 assigned this task to Reedy.

Last call to the deprecated API was on 2022-07-19 per https://logstash.wikimedia.org/goto/7ce698170eeb7ea1debb1bad729c852c. This corresponds with a new deployment of Striker for T306469 which included @Reedy's patch.