Page MenuHomePhabricator
Create Task
Maniphest T304890

Fix uses of (error|success|warning|message)box in Flow
Closed, ResolvedPublic
Actions

Description

See T300306: [subtask] successbox, errorbox and warningbox classes will no longer function in 1.39 release for details.

Details

SubjectRepoBranchLines +/-
Drop usages of errorboxmediawiki/extensions/Flowmaster+31 -31
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh created this task.Mar 28 2022, 7:23 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptMar 28 2022, 7:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kostajh mentioned this in T300346: Fix uses of (error|success|warning|message)box in GrowthExperiments.Mar 28 2022, 7:24 PM
Jdlrobson subscribed.Mar 28 2022, 11:16 PM
Sgs subscribed.Mar 29 2022, 10:50 AM

There are around 10 instances of errorbox used for overwriting core styles, so ideally we should use our own dedicated class for it. I can post a patch for this.

Sgs claimed this task.Mar 29 2022, 10:51 AM
kostajh triaged this task as Medium priority.Mar 29 2022, 11:19 AM
kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
kostajh moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

(Moving to in progress & current sprint as it's been claimed)

Jdlrobson awarded a token.Mar 30 2022, 7:43 PM
gerritbot added a comment.Mar 31 2022, 12:23 PM

Change 775849 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/Flow@master] Drop usages of errorbox

https://gerrit.wikimedia.org/r/775849

gerritbot added a project: Patch-For-Review.Mar 31 2022, 12:23 PM
Sgs changed the task status from Open to In Progress.Mar 31 2022, 12:30 PM
Sgs moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Tacsipacsi subscribed.Mar 31 2022, 12:46 PM
gerritbot added a comment.Mar 31 2022, 6:08 PM

Change 775849 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Drop usages of errorbox

https://gerrit.wikimedia.org/r/775849

Maintenance_bot removed a project: Patch-For-Review.Mar 31 2022, 6:10 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.6; 2022-04-04).Mar 31 2022, 7:00 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 31 2022, 7:44 PM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Apr 1 2022, 12:45 AM
Etonkovidova closed this task as Resolved.Apr 5 2022, 11:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL