Page MenuHomePhabricator

Properly fall back to prefixsearch when CirrusSearch returns nothing
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

As described in T303524 there are apparently situations where CirrusSearch somehow fails and returns nothing. It should fall back to the top 10 prefixsearch results in this case.

Note this task is exclusively about this edge case. It's not about situations where mixing the two search APIs might be a thing. This is to be discussed in other tickets.

Event Timeline

thiemowmde moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-03-16 board.
thiemowmde set the point value for this task to 0.

Change 774868 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TemplateWizard@master] Full fallback to prefixsearch when Cirrus returns nothing

https://gerrit.wikimedia.org/r/774868

Change 774872 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Full fallback to prefixsearch when Cirrus returns nothing

https://gerrit.wikimedia.org/r/774872

thiemowmde changed the point value for this task from 0 to 1.Mar 30 2022, 8:58 AM
thiemowmde set Final Story Points to 3.

Change 774868 merged by jenkins-bot:

[mediawiki/extensions/TemplateWizard@master] Full fallback to prefixsearch when Cirrus returns nothing

https://gerrit.wikimedia.org/r/774868

Change 774872 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Full fallback to prefixsearch when Cirrus returns nothing

https://gerrit.wikimedia.org/r/774872

Demoed today. The fallback that's already live on Wikimedia Commons is that we now see at least 1 search result – the top 1 prefixsearch result. A more complete fallback to 10 results is already merged, just not deployed. This will be demoed via T303524.