[Bug] Old Table of Contents appears with new Table of Contents after editing page with Visual Editor
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	• nray
	Mar 29 2022, 7:14 PM

Description

Steps to reproduce

Login and visit https://en.wikipedia.beta.wmflabs.org/wiki/Bananab . Assert that the new table of contents appears in the sidebar.
Click the "Edit this page" button and make sure it goes directly to Visual Editor and the not source editor. If it goes to source editor first, this bug won't be replicated.
Make an edit
Click Publish Change button

Expected results

Content is saved without another Table of Contents appearing

Actual results

Content appears and two table of contents are visible on the page (one in the sidebar and one in the content)

Screen Shot 2022-03-29 at 1.12.33 PM.png (2×3 px, 495 KB)

https://jumpshare.com/v/eL8TWC8CblJfPuOphVzK

Environments observed

Browser version: Chrome
OS version: Mac
Device model:
Device language: en

Check any additional observations

Observed on the beta cluster wiki
Observed on a production wiki
Observed on Vector desktop skin
Observed on MinervaNeue responsive skin
Observed while logged in
Observed while not logged in (anonymous)

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		ovasileva	T273473 [Epic] Improve the table of contents
Resolved		ovasileva	T304169 [Goal] Begin table of contents A/B test
Resolved	BUG REPORT	• nray	T304987 [Bug] Old Table of Contents appears with new Table of Contents after editing page with Visual Editor

Event Timeline

• nray created this task.Mar 29 2022, 7:14 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptMar 29 2022, 7:14 PM

• nray edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog.Mar 29 2022, 7:14 PM

• nray added a parent task: T273473: [Epic] Improve the table of contents.

• nray updated the task description. (Show Details)Mar 29 2022, 7:18 PM

• nray updated the task description. (Show Details)Mar 29 2022, 7:36 PM

Observed on Vector desktop skin

How you are replicating this one? Production should only show the table of contents with the query string parameter and this won't be passed to the API on save.

Observed on the beta cluster wiki

I can't replicate this on the beta cluster, so I suspect something about our setups is different (maybe a preference?) and I want to understand.

Could you look at the request headers for the POST that happens after you hit save? Can you confirm vector-2022 is being sent for the useskin value?

en.wikipedia.beta.wmflabs.org/w/api.php

save
Content-Disposition: form-data; name="useskin"

vector-2022
-----------------------------

In the response I see:

visualeditoredit	Object { result: "success", content: "<div class=\"mw-parser-output\"><mw:tocplace></mw:tocplace>

but I'm guessing for you there's no mw:tocplace?

ovasileva triaged this task as High priority.Mar 30 2022, 2:15 PM

In T304987#7816718, @Jdlrobson wrote:

Observed on Vector desktop skin

How you are replicating this one? Production should only show the table of contents with the query string parameter and this won't be passed to the API on save.

Sorry, I thought that checkbox was just saying that I observed it on the vector skin and I didn't notice the production url. I haven't replicated on production, only on beta.

Observed on the beta cluster wiki

I can't replicate this on the beta cluster, so I suspect something about our setups is different (maybe a preference?) and I want to understand.

Could you look at the request headers for the POST that happens after you hit save? Can you confirm vector-2022 is being sent for the useskin value?

en.wikipedia.beta.wmflabs.org/w/api.php
save
Content-Disposition: form-data; name="useskin"

vector-2022
-----------------------------
In the response I see:
visualeditoredit	Object { result: "success", content: "<div class=\"mw-parser-output\"><mw:tocplace></mw:tocplace>
but I'm guessing for you there's no mw:tocplace?

I tried to look more in depth this morning but ran into a (seemingly unrelated) error when I click the "Publish changes" button

Screen Shot 2022-03-30 at 9.53.27 AM.png (2×3 px, 612 KB)

which didn't happen yesterday. However, the xhr payload that is being sent reports vector-2022:

Screen Shot 2022-03-30 at 9.59.51 AM.png (270×538 px, 31 KB)

• nray updated the task description. (Show Details)Mar 30 2022, 4:01 PM

Can you try again now? Editing issue appears to be fixed.

@Jdlrobson For whatever reason, it appears to be working now on both local and beta lol. I can't replicate it despite being able to on both yesterday 🤷

LGoto assigned this task to • nray.Mar 31 2022, 5:08 PM

ovasileva added a parent task: T304169: [Goal] Begin table of contents A/B test.Apr 4 2022, 9:58 AM

For the last several days, I've tried replicating this bug on both beta and locally and have been unable to do so. It isn't clear to me how I could replicate it last week, but something must have changed. Given that I can't replicate it anymore, I am resolving this

	F35030276: Screen Shot 2022-03-30 at 9.53.27 AM.png
	Mar 30 2022, 4:01 PM

	F35030281: Screen Shot 2022-03-30 at 9.59.51 AM.png
	Mar 30 2022, 4:01 PM

	F35028859: Screen Shot 2022-03-29 at 1.12.33 PM.png
	Mar 29 2022, 7:14 PM

[Bug] Old Table of Contents appears with new Table of Contents after editing page with Visual EditorClosed, ResolvedPublicBUG REPORTActions