Page MenuHomePhabricator

Handle mpeg files with an aspect ratio of 0
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:

  • width is 0

What should have happened instead?:

  • width should have been 636px

This is because in mpeg handler we have: $width = (int)( $width * $aspect ); but for this file the aspect ratio is 0. It is not know if this is allowed in mpeg1/2

Event Timeline

@brion I see in the past you made several comments on ID3 relating to aspect ratio issues in MPEG via https://github.com/JamesHeinrich/getID3/issues/148

Is this issue related to that perhaps ?

Change #1301702 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] MPEG: fall back to square pixels when AR is invalid

https://gerrit.wikimedia.org/r/1301702

Change #1301702 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] MPEG: fall back to square pixels when AR is invalid

https://gerrit.wikimedia.org/r/1301702

TheDJ claimed this task.