List of steps to reproduce (step by step, including full links if applicable):
- If the account has already selected topics, clear the selection via:
new mw.Api().saveOptions({
'growthexperiments-homepage-suggestededits-activated': '',
'growthexperiments-homepage-se-ores-topic-filters' : '',
'growthexperiments-homepage-se-filters': ''
})- Select an unstructured task without selecting any topics
- Publish an edit
- Close the post-edit dialog
- Publish another edit
What happens?:
The post-edit dialog is not shown for the subsequent edit. This warning is present in the browser console.
load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets|oojs-ui.styles.icons-editing-advanced&skin=vector&version=e0r8n:52 jQuery.Deferred exception: Cannot read properties of null (reading 'getTopics') TypeError: Cannot read properties of null (reading 'getTopics')
at setup (<anonymous>:7:707)
at <anonymous>:8:597
at mightThrow (http://localhost:8080/w/load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets%7Coojs-ui.styles.icons-editing-advanced&skin=vector&version=e0r8n:49:881)
at process (http://localhost:8080/w/load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets%7Coojs-ui.styles.icons-editing-advanced&skin=vector&version=e0r8n:50:544) undefinedWhat should have happened instead?:
The post-edit dialog should be shown whenever an edit is published (for unstructured tasks only).
Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
When the user is in this state, it looks like the promise for closing the post-edit dialog is never resolved so postEditDialogIsOpen is still true in suggestedEditSession so the post-edit dialog is not shown for the subsequent edit.