Page MenuHomePhabricator
Create Task
Maniphest T305098

Error and warning boxes in account creation appear incorrectly
Closed, ResolvedPublic
Actions

Description

Error and warning boxes in account creation appear incorrectly.

https://en.wikipedia.org/wiki/Special:CreateAccount

image.png (2×3 px, 342 KB)

image.png (2×3 px, 372 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix error/warning boxes on signup formmediawiki/corewmf/1.39.0-wmf.5+2 -1
Fix error/warning boxes on signup formmediawiki/coremaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

• matmarex created this task.Mar 30 2022, 6:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 30 2022, 6:50 PM
• matmarex added a subscriber: Stang.Mar 30 2022, 6:51 PM

Probably caused by rMW9c70df0cf6c2: Fix uses of (error|warning|success)box in core

Tacsipacsi changed the task status from Open to In Progress.Mar 30 2022, 7:23 PM
Tacsipacsi claimed this task.
Tacsipacsi subscribed.

It seems to be easy to fix.

gerritbot added a comment.Mar 30 2022, 7:31 PM

Change 775381 had a related patch set uploaded (by Tacsipacsi; author: Tacsipacsi):

[mediawiki/core@master] Fix error/warning boxes on signup form

https://gerrit.wikimedia.org/r/775381

gerritbot added a project: Patch-For-Review.Mar 30 2022, 7:31 PM
gerritbot added a comment.Mar 30 2022, 7:52 PM

Change 775381 merged by jenkins-bot:

[mediawiki/core@master] Fix error/warning boxes on signup form

https://gerrit.wikimedia.org/r/775381

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.6; 2022-04-04).Mar 30 2022, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 30 2022, 8:10 PM
Tacsipacsi added a comment.Mar 30 2022, 9:01 PM

This looked quite broken before the fix. While probably not many people use this page, these are their first impressions about Wikipedia, so I think the fix should be backported. Anyone? The last window today has just ended, but there are windows tomorrow.

gerritbot added a comment.Mar 31 2022, 12:05 PM

Change 775432 had a related patch set uploaded (by Bartosz Dziewoński; author: Tacsipacsi):

[mediawiki/core@wmf/1.39.0-wmf.5] Fix error/warning boxes on signup form

https://gerrit.wikimedia.org/r/775432

gerritbot added a project: Patch-For-Review.Mar 31 2022, 12:05 PM
• matmarex added a comment.Mar 31 2022, 12:05 PM

I'll schedule it for https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20220331T1300

gerritbot added a comment.Mar 31 2022, 1:47 PM

Change 775432 merged by jenkins-bot:

[mediawiki/core@wmf/1.39.0-wmf.5] Fix error/warning boxes on signup form

https://gerrit.wikimedia.org/r/775432

Stashbot added a comment.Mar 31 2022, 1:51 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-31T13:51:27Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.39.0-wmf.5/resources/src/mediawiki.special.createaccount/HtmlformChecker.js: Backport: [[gerrit:775432|Fix error/warning boxes on signup form (T305098)]] (duration: 00m 50s)

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.5; 2022-03-28); removed MW-1.39-notes (1.39.0-wmf.6; 2022-04-04).Mar 31 2022, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 31 2022, 2:10 PM
• matmarex closed this task as Resolved.Mar 31 2022, 6:38 PM
Jdlrobson added a comment.Mar 31 2022, 11:28 PM

Thanks @matmarex for the backport here and thanks @Tacsipacsi for getting this patched.

Stang unsubscribed.Apr 5 2022, 12:22 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits