Maniphest T305100

Remove trace and collation support from SectionProfiler
Closed, ResolvedPublic
Actions

Description

Currently unused and untested.

Came up in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/774945/.

new SectionProfiler is used in three places in all of Codesearch indexed repos, all within core, and without arguments, thus not enabling the trace option. Most of the code in SectionProfiler is only relevant to the trace option.

Methods actually used:

scopedProfileIn
scopedProfileOut
getFunctionStats

Details

	Subject	Repo	Branch	Lines +/-
	profiler: Remove deprecated 'trace' feature in SectionProfiler	mediawiki/core	master	+7 -189
	profiler: Deprecate unused 'trace' option	mediawiki/core	master	+6 -0
	profiler: Deprecate unused 'trace' option	mediawiki/core	REL1_38	+6 -0

Customize query in gerrit

Event Timeline

Krinkle created this task.Mar 30 2022, 7:16 PM

Restricted Application added a project: Performance-Team. · View Herald TranscriptMar 30 2022, 7:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Krinkle added a project: Technical-Debt (Deprecation process).Mar 30 2022, 7:16 PM

Krinkle moved this task from Untriaged to 2022 | MW 1.38 / 1.39 on the Technical-Debt (Deprecation process) board.

Change 776356 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] [WIP] profiler: Remove unused trace-related methods

https://gerrit.wikimedia.org/r/776356

gerritbot added a project: Patch-For-Review.Apr 3 2022, 5:37 PM

Krinkle claimed this task.Apr 3 2022, 5:59 PM

Krinkle triaged this task as Low priority.

Krinkle moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.Apr 4 2022, 6:17 PM

Change 778615 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] profiler: Deprecate unused 'trace' option

https://gerrit.wikimedia.org/r/778615

Change 779878 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@REL1_38] profiler: Deprecate unused 'trace' option

https://gerrit.wikimedia.org/r/779878

Change 778615 merged by jenkins-bot:

[mediawiki/core@master] profiler: Deprecate unused 'trace' option

https://gerrit.wikimedia.org/r/778615

Change 779878 merged by jenkins-bot:

[mediawiki/core@REL1_38] profiler: Deprecate unused 'trace' option

https://gerrit.wikimedia.org/r/779878

ReleaseTaggerBot added projects: MW-1.38-notes, MW-1.39-notes (1.39.0-wmf.8; 2022-04-18).Apr 13 2022, 10:00 PM

Change 776356 merged by jenkins-bot:

[mediawiki/core@master] profiler: Remove deprecated 'trace' feature in SectionProfiler

https://gerrit.wikimedia.org/r/776356

Maintenance_bot removed a project: Patch-For-Review.Apr 29 2022, 7:30 PM

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.10; 2022-05-02); removed MW-1.39-notes (1.39.0-wmf.8; 2022-04-18).Apr 29 2022, 8:00 PM

Krinkle closed this task as Resolved.May 1 2022, 10:21 PM