Maniphest T305113

[EPIC] Remove mobile history page
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Jdlrobson
	Mar 30 2022, 10:34 PM

Tags

Referenced Files

	F35030739: Screen Shot 2022-03-30 at 3.31.34 PM.png
	Mar 30 2022, 10:34 PM

	F35030738: Screen Shot 2022-03-30 at 3.31.10 PM.png
	Mar 30 2022, 10:34 PM

Subscribers

Tokens

"Like" token, awarded by Izno."Like" token, awarded by Ladsgroup.

Description

Every page view to the history page on mobile leads to a redirect. The mobile history page is provided by SpecialMobileHistory which is 336 lines of code.

The two designs are very closely aligned as demonstrated in the screenshot below. The existing mobile design could easily be realized with a CSS only solution.

The existing code has required security patches.

Screen Shot 2022-03-30 at 3.31.10 PM.png (1×2 px, 195 KB)

Screen Shot 2022-03-30 at 3.31.34 PM.png (1×2 px, 179 KB)

TODO

Add CSS to the desktop page to style identically to the existing mobile.
Switch all sites to use desktop HTML
Remove includes/specials/SpecialMobileHistory.php
Remove redirect logic

Details

	Subject	Repo	Branch	Lines +/-
	Style the desktop diff and history page of Minerva to look like mobile pages	mediawiki/skins/MinervaNeue	master	+340 -6
	HistoryPager: Mark current and previous links	mediawiki/core	master	+11 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T305113 [EPIC] Remove mobile history page
		Duplicate	BUG REPORT	None	T327566 Mobile Page history HTML differ, making scripting hard
		Duplicate		None	T350609 Disable the mobile history page and use desktop instead
		Resolved		Jdlrobson	T353388 Enable desktop history HTML on mobile
		Resolved	BUG REPORT	jsn.sherman	T353401 Non-functional input appears on desktop history page when viewed in mobile site
		Resolved	BUG REPORT	Jdlrobson	T353403 Talk and article tabs should appear on history page in Minerva
		Resolved		Jdlrobson	T353485 Not possible to click history rows when hovering over the date
		Resolved		Edtadros	T354218 Long edit summaries spill out of container on history page
		Resolved	BUG REPORT	Edtadros	T355369 History page: Username does not wrap.
		Resolved		ovasileva	T356120 Decommision the Special:History page

Event Timeline

Jdlrobson created this task.Mar 30 2022, 10:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 30 2022, 10:34 PM

Jdlrobson moved this task from Simplify MobileFrontend to Remove mobile Watchlist special page on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Mar 31 2022, 7:04 PM

Jdlrobson updated the task description. (Show Details)Oct 31 2022, 11:42 PM

Jdlrobson mentioned this in T320987: CVE-2023-22909: [Unplanned, S] Mobile frontend's history makes really slow db queries.Nov 7 2022, 9:39 PM

Ladsgroup awarded a token.Nov 10 2022, 12:07 PM

Jdlrobson added a project: MobileFrontend (MobileFrontend Special Pages).Jan 23 2023, 3:39 PM

Jdlrobson added a subtask: T327566: Mobile Page history HTML differ, making scripting hard.

Jdlrobson moved this task from Backlog to History on the MobileFrontend (MobileFrontend Special Pages) board.

Jdlrobson triaged this task as Low priority.Mar 15 2023, 5:42 PM

Jdlrobson mentioned this in T340158: rename Special:History to Special:MobileHistory?.Jun 30 2023, 7:53 PM

Novem_Linguae subscribed.Jun 30 2023, 8:46 PM

Frostly subscribed.Oct 14 2023, 9:06 PM

Change 966309 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] HistoryPager: Mark current and previous links

https://gerrit.wikimedia.org/r/966309

gerritbot added a project: Patch-For-Review.Oct 16 2023, 10:51 PM

Change 962095 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] WIP: Style the desktop diff and history page of Minerva to look like mobile pages

https://gerrit.wikimedia.org/r/962095

Change 966309 merged by jenkins-bot:

[mediawiki/core@master] HistoryPager: Mark current and previous links

https://gerrit.wikimedia.org/r/966309

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.2; 2023-10-24).Oct 18 2023, 2:00 AM

Change 962095 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Style the desktop diff and history page of Minerva to look like mobile pages

https://gerrit.wikimedia.org/r/962095

Maintenance_bot removed a project: Patch-For-Review.Oct 30 2023, 3:10 PM

Jdlrobson changed the status of subtask T327566: Mobile Page history HTML differ, making scripting hard from Open to Stalled.Nov 6 2023, 5:51 PM

Jdlrobson raised the priority of this task from Low to Medium.Dec 13 2023, 10:03 PM

Jdlrobson mentioned this in T177260: Rewrite disabled MobileFrontend browser tests to phpunit tests and Node.js browser tests.

Jdlrobson moved this task from Remove mobile Watchlist special page to Remove mobile diff and history page on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Jan 8 2024, 10:44 PM

Jdlrobson closed subtask T353388: Enable desktop history HTML on mobile as Resolved.Jan 29 2024, 10:31 PM

Jdlrobson updated the task description. (Show Details)Jan 29 2024, 10:34 PM

thiemowmde mentioned this in T356725: Revision Slider clutters mobile UI.Feb 7 2024, 3:41 PM

Izno awarded a token.Feb 21 2024, 4:50 AM

Jdlrobson closed this task as Resolved.Mar 4 2024, 5:06 PM

Jdlrobson updated the task description. (Show Details)

ovasileva closed subtask T356120: Decommision the Special:History page as Resolved.Mar 8 2024, 2:15 PM

Jdlrobson mentioned this in T298988: "Change visibility of selected revisions" button out of alignment on revision history on Minerva.Mar 21 2024, 4:34 PM