Page MenuHomePhabricator
Create Task
Maniphest T305131

Link to documentation in a new tab for the "learn more" link on the MT warning and error messages
Closed, ResolvedPublic
Actions

Assigned To
ngkountas
Authored By
Pginer-WMF
Mar 31 2022, 9:32 AM
Tags
Referenced Files
F35278783: Screen Shot 2022-06-26 at 11.31.57 PM.png
Jun 27 2022, 4:47 AM
F35048311: Screen Shot 2022-04-12 at 10.06.06 AM.png
Apr 12 2022, 5:11 PM
F35048314: Screen Shot 2022-04-12 at 9.31.52 AM.png
Apr 12 2022, 5:11 PM
Subscribers
Aklapper
EChukwukere-WMF
Etonkovidova
ngkountas
Pginer-WMF
• RodneyAraujo
santhosh
View All 10 Subscribers

Description

In the step for previewing and confirming a mobile translation (T252542), an error or warning message can be shown.
These messages contain a "learn more" link that is expected to (a) point to relevant documentation and (b) open on a new tab.

However, currently, taping on them causes the editor to restart the translation in the same tab, which can be confusing and make users lose their work.

This ticket proposes to adjust those links int he following way:

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
SX Publisher "Learn more" message: Use external link to documentationmediawiki/extensions/ContentTranslationmaster+1 -1
CX3 Build 0.2.0+20220404mediawiki/extensions/ContentTranslationmaster+112 -89
SX: Fix "learn more" link inside MT warning/error panelmediawiki/extensions/ContentTranslationmaster+16 -9
Customize query in gerrit

Related Objects
Search...

Event Timeline

Pginer-WMF created this task.Mar 31 2022, 9:32 AM
Pginer-WMF triaged this task as Medium priority.
Pginer-WMF added a project: Language-Team (Language-2022-April-June).
Pginer-WMF moved this task from Quarter Backlog to Priority: SX Adoption on the Language-Team (Language-2022-April-June) board.
Pginer-WMF mentioned this in T302791: Adjust error message for the publish step.Mar 31 2022, 9:42 AM
Pginer-WMF moved this task from Backlog to Mobile editor on the SectionTranslation board.Mar 31 2022, 11:31 AM
ngkountas claimed this task.Apr 1 2022, 4:47 PM
ngkountas moved this task from Priority: SX Adoption to In Progress on the Language-Team (Language-2022-April-June) board.
ngkountas moved this task from In Progress to In Review on the Language-Team (Language-2022-April-June) board.
gerritbot added a comment.Apr 1 2022, 4:54 PM

Change 776238 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Fix "learn more" link inside MT warning/error panel

https://gerrit.wikimedia.org/r/776238

gerritbot added a project: Patch-For-Review.Apr 1 2022, 4:54 PM
gerritbot added a comment.Apr 4 2022, 4:46 AM

Change 776238 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Fix "learn more" link inside MT warning/error panel

https://gerrit.wikimedia.org/r/776238

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.6; 2022-04-04).Apr 4 2022, 5:00 AM
gerritbot added a comment.Apr 4 2022, 5:01 AM

Change 776470 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20220404

https://gerrit.wikimedia.org/r/776470

gerritbot added a comment.Apr 4 2022, 10:27 AM

Change 776470 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20220404

https://gerrit.wikimedia.org/r/776470

Maintenance_bot removed a project: Patch-For-Review.Apr 4 2022, 10:30 AM
ngkountas moved this task from In Review to Needs QA on the Language-Team (Language-2022-April-June) board.Apr 8 2022, 1:00 PM
ngkountas added a comment.Apr 8 2022, 1:58 PM

The cx-sx-publisher-review-info-learn-more translation message must be fixed in each language to contain a link in wikitext, so that the "Learn more" link can properly work in the corresponding wiki.

Etonkovidova moved this task from Needs QA to Pending input for QA on the Language-Team (Language-2022-April-June) board.Apr 12 2022, 5:11 PM
Etonkovidova subscribed.
In T305131#7840925, @ngkountas wrote:

The cx-sx-publisher-review-info-learn-more translation message must be fixed in each language to contain a link in wikitext, so that the "Learn more" link can properly work in the corresponding wiki.

Currently, the link Learn more on "Confirm publication" points to the error page, e.g. https://th.m.wikipedia.org/w/mw:Special:MyLanguage/Help:Content_translation/Translating/Translation_quality

Screen Shot 2022-04-12 at 9.31.52 AM.png (1×664 px, 137 KB)

The link under Did you mean: - https://www.mediawiki.org/wiki/Help:Content_translation/Translating/Translation_quality points to the correct page.

<div class="col sx-publisher__review-info__learn-more-anchor"><a href="./mw:Special:MyLanguage/Help:Content_translation/Translating/Translation_quality" title="mw:Special:MyLanguage/Help:Content_translation/Translating/Translation_quality" target="_blank">Learn more</a></div>

Screen Shot 2022-04-12 at 10.06.06 AM.png (1×2 px, 171 KB)

gerritbot added a comment.May 18 2022, 11:58 AM

Change 793032 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX Publisher "Learn more" message: Use external link to documentation

https://gerrit.wikimedia.org/r/793032

gerritbot added a project: Patch-For-Review.May 18 2022, 11:58 AM
ngkountas moved this task from Pending input for QA to In Review on the Language-Team (Language-2022-April-June) board.May 20 2022, 7:20 AM
gerritbot added a comment.May 23 2022, 10:49 AM

Change 793032 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX Publisher "Learn more" message: Use external link to documentation

https://gerrit.wikimedia.org/r/793032

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.13; 2022-05-23); removed MW-1.39-notes (1.39.0-wmf.6; 2022-04-04).May 23 2022, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.May 23 2022, 11:31 AM
santhosh moved this task from In Review to Recheck after deployment on the Language-Team (Language-2022-April-June) board.May 24 2022, 4:04 AM
EChukwukere-WMF subscribed.Jun 22 2022, 3:28 AM

Clicking the learn more hyperlink navigates to the content translation documentation page for further information. Clicking the back button navigates the user back to the ready to publish/ modified text page with the learn more hyperlink

EChukwukere-WMF moved this task from Recheck after deployment to Done on the Language-Team (Language-2022-April-June) board.Jun 22 2022, 3:29 AM
Pginer-WMF added a comment.Jun 22 2022, 7:27 AM
In T305131#8018686, @EChukwukere-WMF wrote:

Clicking the learn more hyperlink navigates to the content translation documentation page for further information. Clicking the back button navigates the user back to the ready to publish/ modified text page with the learn more hyperlink

Thanks for checking this . Can you confirm the two points below are supported?

  • Open the link on a new tab/window to avoid losing the current work.
  • Make sure that these changes are applied to both the warning and the error message.

The comment about back button seemed to suggest the link was opened in the same window but wanted to confirm.

EChukwukere-WMF added a comment.EditedJun 27 2022, 4:47 AM

@Pginer-WMF yes when you click the warnings and errors it is opened in a different tab any time you click it. The error of restarting the editor does not occur

Tested in both mobile firefox and and chrome as shown in the image below:

Screen Shot 2022-06-26 at 11.31.57 PM.png (767×394 px, 150 KB)

Pginer-WMF closed this task as Resolved.Jun 27 2022, 8:41 AM

Perfect. Thanks for confirming @EChukwukere-WMF!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits