Page MenuHomePhabricator

Link to documentation in a new tab for the "learn more" link on the MT warning and error messages
Closed, ResolvedPublic

Description

In the step for previewing and confirming a mobile translation (T252542), an error or warning message can be shown.
These messages contain a "learn more" link that is expected to (a) point to relevant documentation and (b) open on a new tab.

However, currently, taping on them causes the editor to restart the translation in the same tab, which can be confusing and make users lose their work.

This ticket proposes to adjust those links int he following way:

Event Timeline

Change 776238 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Fix "learn more" link inside MT warning/error panel

https://gerrit.wikimedia.org/r/776238

Change 776238 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Fix "learn more" link inside MT warning/error panel

https://gerrit.wikimedia.org/r/776238

Change 776470 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20220404

https://gerrit.wikimedia.org/r/776470

Change 776470 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20220404

https://gerrit.wikimedia.org/r/776470

The cx-sx-publisher-review-info-learn-more translation message must be fixed in each language to contain a link in wikitext, so that the "Learn more" link can properly work in the corresponding wiki.

Etonkovidova added a subscriber: Etonkovidova.

The cx-sx-publisher-review-info-learn-more translation message must be fixed in each language to contain a link in wikitext, so that the "Learn more" link can properly work in the corresponding wiki.

Currently, the link Learn more on "Confirm publication" points to the error page, e.g. https://th.m.wikipedia.org/w/mw:Special:MyLanguage/Help:Content_translation/Translating/Translation_quality

Screen Shot 2022-04-12 at 9.31.52 AM.png (1×664 px, 137 KB)

The link under Did you mean: - https://www.mediawiki.org/wiki/Help:Content_translation/Translating/Translation_quality points to the correct page.

<div class="col sx-publisher__review-info__learn-more-anchor"><a href="./mw:Special:MyLanguage/Help:Content_translation/Translating/Translation_quality" title="mw:Special:MyLanguage/Help:Content_translation/Translating/Translation_quality" target="_blank">Learn more</a></div>

Screen Shot 2022-04-12 at 10.06.06 AM.png (1×2 px, 171 KB)

Change 793032 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX Publisher "Learn more" message: Use external link to documentation

https://gerrit.wikimedia.org/r/793032

Change 793032 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX Publisher "Learn more" message: Use external link to documentation

https://gerrit.wikimedia.org/r/793032

Clicking the learn more hyperlink navigates to the content translation documentation page for further information. Clicking the back button navigates the user back to the ready to publish/ modified text page with the learn more hyperlink

Clicking the learn more hyperlink navigates to the content translation documentation page for further information. Clicking the back button navigates the user back to the ready to publish/ modified text page with the learn more hyperlink

Thanks for checking this . Can you confirm the two points below are supported?

  • Open the link on a new tab/window to avoid losing the current work.
  • Make sure that these changes are applied to both the warning and the error message.

The comment about back button seemed to suggest the link was opened in the same window but wanted to confirm.

@Pginer-WMF yes when you click the warnings and errors it is opened in a different tab any time you click it. The error of restarting the editor does not occur

Tested in both mobile firefox and and chrome as shown in the image below:

Screen Shot 2022-06-26 at 11.31.57 PM.png (767×394 px, 150 KB)

Perfect. Thanks for confirming @EChukwukere-WMF!