The sticky header is not displayed in Darkmode on Vector 2022
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Falloutgen
	Mar 31 2022, 1:34 PM

Description

Hello,

We are currently using the "DarkeMode" extension for switching from dark to light mode on Vector 2022 and it seems that it does not handle the sticky header:

The header tag goes from "vector-sticky-header" to "vector-sticky-header vector-sticky-header-visible" in both cases, no specific errors in the logs.

See in production version : fallout-wiki.com

Thanks for your work,

Sincerely,

Kims

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/DarkMode	REL1_38	+8 -3	Add class to the <html> element instead of <body>
	mediawiki/extensions/DarkMode	master	+8 -3	Add class to the <html> element instead of <body>

Customize query in gerrit

Related Objects

Mentioned In: rEDKMb2dbb1e2e26c: Add class to the <html> element instead of <body>
rEDKM894bd091c811: Add class to the <html> element instead of <body>
T313283: Elements with position fixed, sticky, etc. break with DarkMode in Firefox
Mentioned Here: T313283: Elements with position fixed, sticky, etc. break with DarkMode in Firefox

Event Timeline

Falloutgen created this task.Mar 31 2022, 1:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2022, 1:34 PM

Clarasiir mentioned this in T313283: Elements with position fixed, sticky, etc. break with DarkMode in Firefox.Tue, Jul 19, 4:19 AM

Change 818627 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/DarkMode@master] Add class to the <html> element instead of <body>

https://gerrit.wikimedia.org/r/818627

gerritbot added a project: Patch-For-Review.Sun, Jul 31, 11:59 PM

Change 818627 merged by jenkins-bot:

[mediawiki/extensions/DarkMode@master] Add class to the <html> element instead of <body>

https://gerrit.wikimedia.org/r/818627

MusikAnimal mentioned this in rEDKM894bd091c811: Add class to the <html> element instead of <body>.Mon, Aug 1, 12:20 AM

When I get a chance to test it, I'll backport this fix to the REL1_38 branch. If you're using master, it should now be fixed.

Note however this may still be broken in Firefox due to a browser bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1650522

We could leave this open and tag with Upstream but I think the browser bug issue may deserve it's own task (if anyone wants to create it). For now, I will consider this resolved as we've done all we can do with https://gerrit.wikimedia.org/r/818627.

Actually it looks like there's already a task that can now serve as the tracking task for the Firefox issue: T313283: Elements with position fixed, sticky, etc. break with DarkMode in Firefox

Maintenance_bot removed a project: Patch-For-Review.Mon, Aug 1, 12:30 AM

Test wiki created on Patch demo by MusikAnimal using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/fc30b3c782/w

Test wiki on Patch demo by MusikAnimal using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/fc30b3c782/w/~~

Test wiki created on Patch demo by MusikAnimal using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/7d174d3357/w

Change 819620 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/DarkMode@REL1_38] Add class to the <html> element instead of <body>

https://gerrit.wikimedia.org/r/819620

gerritbot added a project: Patch-For-Review.Tue, Aug 2, 8:48 PM

Change 819620 merged by jenkins-bot: