Page MenuHomePhabricator

The sticky header is not displayed in Darkmode on Vector 2022
Closed, ResolvedPublicBUG REPORT

Description

Hello,

We are currently using the "DarkeMode" extension for switching from dark to light mode on Vector 2022 and it seems that it does not handle the sticky header:

image.png (958×1 px, 583 KB)

image.png (956×1 px, 612 KB)

The header tag goes from "vector-sticky-header" to "vector-sticky-header vector-sticky-header-visible" in both cases, no specific errors in the logs.

See in production version : fallout-wiki.com

Thanks for your work,

Sincerely,

Kims

Event Timeline

Change 818627 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/DarkMode@master] Add class to the <html> element instead of <body>

https://gerrit.wikimedia.org/r/818627

Change 818627 merged by jenkins-bot:

[mediawiki/extensions/DarkMode@master] Add class to the <html> element instead of <body>

https://gerrit.wikimedia.org/r/818627

MusikAnimal claimed this task.

When I get a chance to test it, I'll backport this fix to the REL1_38 branch. If you're using master, it should now be fixed.

Note however this may still be broken in Firefox due to a browser bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1650522

We could leave this open and tag with Upstream but I think the browser bug issue may deserve it's own task (if anyone wants to create it). For now, I will consider this resolved as we've done all we can do with https://gerrit.wikimedia.org/r/818627.

Actually it looks like there's already a task that can now serve as the tracking task for the Firefox issue: T313283: Elements with position fixed, sticky, etc. break with DarkMode in Firefox

Test wiki created on Patch demo by MusikAnimal using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/fc30b3c782/w

Test wiki on Patch demo by MusikAnimal using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/fc30b3c782/w/

Test wiki created on Patch demo by MusikAnimal using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/7d174d3357/w

Change 819620 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/DarkMode@REL1_38] Add class to the <html> element instead of <body>

https://gerrit.wikimedia.org/r/819620

Change 819620 merged by jenkins-bot:

[mediawiki/extensions/DarkMode@REL1_38] Add class to the <html> element instead of <body>

https://gerrit.wikimedia.org/r/819620