Improve coverage of the ContentMetadataCollector interface
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	cscott
	Mar 31 2022, 3:06 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

cscott

Description

Moving a bunch of deferred tasks from T287216: ParserOutput should implement ContentMetadataCollector which are needed for Parsoid to fully reflect the underlying ParserOutput type. In particular, the subtasks will need to be done before Parsoid can replace the legacy parser in the post-edit pipeline.

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Subtype	Assigned	Task
			· · ·
Open		None	T310512 Parsoid and the legacy parser should emit exactly the same ParserOutput metadata
Open		None	T305159 Improve coverage of the ContentMetadataCollector interface
Resolved		None	T292865 Plumb revision information from ParserOptions through to ParserOutput (bypassing Parsoid)
Resolved		cscott	T292868 Migrate boolean flags in ParserOutput to ::setFlag() or ::setOutputFlag() or ::setExtensionData()
Resolved		cscott	T293513 Deprecate and remove ParserOutput::setTOCHTML()
Open		cscott	T293514 Unify ParserOutput::{get,set}{TitleText,DisplayTitle}
Resolved		cscott	T296019 Improve ParserOutput::setLanguageLinks() / ::addLanguageLink()
Resolved		cscott	T296037 ParserOutput::addImage() should take a LinkTarget
Open		None	T296038 ParserOutput::addTemplate() interaction with ParserOptions::getTemplateCallback()
Resolved		None	T296025 ParserOutput::setSections() should be more structured
Resolved		cscott	T296036 Deprecate and remove ParserOutput::isLinkInternal() (or at least mark it as @internal)
Open		None	T300979 Ensure ParserOutput can always be combined asynchronously/out-of-order
Resolved		cscott	T296345 Add ParserOutput::addOutputData() to unify various accumulators in ParserOutput
Open		None	T296352 ParserOutput::addWarningMsg() should take a MessageValue instead of a string
Resolved	BUG REPORT	Jgiannelos	T351931 With parsoid categories are not shown
			· · ·

Event Timeline

cscott created this task.Mar 31 2022, 3:06 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2022, 3:06 PM

Change 775882 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] WIP: Deprecate the use of non-string page property values

https://gerrit.wikimedia.org/r/775882

gerritbot added a project: Patch-For-Review.Mar 31 2022, 3:12 PM

cscott added a subtask: T292865: Plumb revision information from ParserOptions through to ParserOutput (bypassing Parsoid).Mar 31 2022, 3:19 PM

cscott added a subtask: T292868: Migrate boolean flags in ParserOutput to ::setFlag() or ::setOutputFlag() or ::setExtensionData().Mar 31 2022, 3:23 PM

cscott added a subtask: T293513: Deprecate and remove ParserOutput::setTOCHTML().

cscott added a subtask: T293514: Unify ParserOutput::{get,set}{TitleText,DisplayTitle}.

cscott added a subtask: T296019: Improve ParserOutput::setLanguageLinks() / ::addLanguageLink().Mar 31 2022, 3:25 PM

cscott added a subtask: T296037: ParserOutput::addImage() should take a LinkTarget.

cscott added a subtask: T296038: ParserOutput::addTemplate() interaction with ParserOptions::getTemplateCallback().Mar 31 2022, 3:29 PM

cscott added a subtask: T296025: ParserOutput::setSections() should be more structured.

cscott added a subtask: T296036: Deprecate and remove ParserOutput::isLinkInternal() (or at least mark it as @internal).Mar 31 2022, 3:32 PM

cscott added a subtask: T300979: Ensure ParserOutput can always be combined asynchronously/out-of-order.Mar 31 2022, 3:34 PM

cscott added a subtask: T296345: Add ParserOutput::addOutputData() to unify various accumulators in ParserOutput.

cscott added a subtask: T296352: ParserOutput::addWarningMsg() should take a MessageValue instead of a string.

cscott mentioned this in T287216: ParserOutput should implement ContentMetadataCollector.Mar 31 2022, 3:42 PM

ssastry moved this task from Needs Triage to Testing on the Parsoid board.Apr 12 2022, 7:08 AM

cscott added a parent task: T310512: Parsoid and the legacy parser should emit exactly the same ParserOutput metadata.Jun 13 2022, 4:45 PM

• matmarex closed subtask T296025: ParserOutput::setSections() should be more structured as Resolved.Jan 23 2023, 9:34 AM

~~T351931: With parsoid categories are not shown requires ParserOutput::setCategories() which I don't think is covered by a more-specific task (yet)~~

Actually, ContentMetadataCollector already has ::addCategory although it takes a string (db key) and we should probably let it use a LinkTarget now that it can do so.

We still need to just iterate over the categories we see and add them to the PO.

MSantos closed subtask T351931: With parsoid categories are not shown as Resolved.Apr 8 2024, 3:39 PM

cscott closed subtask T296345: Add ParserOutput::addOutputData() to unify various accumulators in ParserOutput as Resolved.Oct 6 2025, 1:17 AM

cscott closed subtask T293513: Deprecate and remove ParserOutput::setTOCHTML() as Resolved.Mar 18 2026, 4:47 PM

cscott closed subtask T292868: Migrate boolean flags in ParserOutput to ::setFlag() or ::setOutputFlag() or ::setExtensionData() as Resolved.Mar 18 2026, 4:51 PM

cscott closed subtask T296037: ParserOutput::addImage() should take a LinkTarget as Resolved.Mar 18 2026, 4:53 PM

cscott closed subtask T296019: Improve ParserOutput::setLanguageLinks() / ::addLanguageLink() as Resolved.Mar 18 2026, 4:59 PM

ssastry closed subtask T296036: Deprecate and remove ParserOutput::isLinkInternal() (or at least mark it as @internal) as Resolved.Thu, Oct 1, 2:59 PM

SLopes-WMF closed subtask T292865: Plumb revision information from ParserOptions through to ParserOutput (bypassing Parsoid) as Resolved.Thu, Oct 8, 2:18 PM