Page MenuHomePhabricator
Create Task
Maniphest T305159

Improve coverage of the ContentMetadataCollector interface
Open, Needs TriagePublic
Actions

Description

Moving a bunch of deferred tasks from T287216: ParserOutput should implement ContentMetadataCollector which are needed for Parsoid to fully reflect the underlying ParserOutput type. In particular, the subtasks will need to be done before Parsoid can replace the legacy parser in the post-edit pipeline.

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenReleaseNoneT84936 Release VisualEditor-MediaWiki as "1.0"
 OpenNoneT50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
 OpenNoneT54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
 OpenNoneT174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
 OpenFeatureNoneT54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
 OpenNoneT55784 [EPIC] Use Parsoid HTML for all page views
 OpenNoneT272987 [EPIC] Parsoid read views for DiscussionTools
 OpenNoneT297840 Populate ParserCache with Parsoid output as a post-edit hook
 OpenNoneT310511 Metadata comparison testing between Parsoid and the legacy parser
 OpenNoneT310512 Parsoid and the legacy parser should emit exactly the same ParserOutput metadata
 OpenNoneT305159 Improve coverage of the ContentMetadataCollector interface
 OpenNoneT292865 Plumb revision information from ParserOptions through to ParserOutput (bypassing Parsoid)
 OpenNoneT292868 Migrate boolean flags in ParserOutput to ::setFlag() or ::setOutputFlag() or ::setExtensionData()
 OpenNoneT293513 Deprecate and remove ParserOutput::setTOCHTML()
 ResolvedcscottT295169 Parser TOC placeholder should be a meta tag
 OpencscottT295168 Ensure <meta typeof="..."> in Parser/Parsoid HTML can't be spoofed from wikitext
 ResolvedmatmarexT218330 Table of contents HTML may be unbalanced
 OpenNoneT293514 Unify ParserOutput::{get,set}{TitleText,DisplayTitle}
 OpencscottT296019 Improve ParserOutput::setLanguageLinks() / ::addLanguageLink()
 OpencscottT296037 ParserOutput::addImage() should take a LinkTarget
 ResolvedcscottT296023 Parsoid needs a core-compatible LinkTarget interface
 OpenNoneT296038 ParserOutput::addTemplate() interaction with ParserOptions::getTemplateCallback()
 ResolvedNoneT296025 ParserOutput::setSections() should be more structured
 OpenNoneT324035 Add "title" as a property of TOCData
 OpenNoneT296036 Deprecate and remove ParserOutput::isLinkInternal() (or at least mark it as @internal)
 OpencscottT300979 Ensure ParserOutput can always be combined asynchronously/out-of-order
 OpenNoneT300307 Ensure JsConfigVars can always be combined asynchronously/out-of-order
 OpencscottT300980 Store page indicators as a set; select one at output time
 OpencscottT300981 Ensure extensionData can always be combined asynchronously/out-of-order
 OpencscottT301004 Use OutputPage::appendExtensionData for wikibase-otherprojects-sidebar
 OpencscottT300986 Ensure Page Properties can always be combined asynchronously/out-of-order
 OpencscottT353530 Category defaultsort should be applied in CategoryLinkTable.php
 OpencscottT296345 Add ParserOutput::addOutputData() to unify various accumulators in ParserOutput
 OpenNoneT296352 ParserOutput::addWarningMsg() should take a MessageValue instead of a string
 OpenNoneT296353 Create composer library for includes/libs/Message
 ResolvedBUG REPORTJgiannelosT351931 With parsoid categories are not shown

Event Timeline

cscott created this task.Mar 31 2022, 3:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2022, 3:06 PM
gerritbot added a comment.Mar 31 2022, 3:12 PM

Change 775882 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] WIP: Deprecate the use of non-string page property values

https://gerrit.wikimedia.org/r/775882

gerritbot added a project: Patch-For-Review.Mar 31 2022, 3:12 PM
cscott added a subtask: T292865: Plumb revision information from ParserOptions through to ParserOutput (bypassing Parsoid).Mar 31 2022, 3:19 PM
cscott added a subtask: T292868: Migrate boolean flags in ParserOutput to ::setFlag() or ::setOutputFlag() or ::setExtensionData().Mar 31 2022, 3:23 PM
cscott added a subtask: T293513: Deprecate and remove ParserOutput::setTOCHTML().
cscott added a subtask: T293514: Unify ParserOutput::{get,set}{TitleText,DisplayTitle}.
cscott added a subtask: T296019: Improve ParserOutput::setLanguageLinks() / ::addLanguageLink().Mar 31 2022, 3:25 PM
cscott added a subtask: T296037: ParserOutput::addImage() should take a LinkTarget.
cscott added a subtask: T296038: ParserOutput::addTemplate() interaction with ParserOptions::getTemplateCallback().Mar 31 2022, 3:29 PM
cscott added a subtask: T296025: ParserOutput::setSections() should be more structured.
cscott added a subtask: T296036: Deprecate and remove ParserOutput::isLinkInternal() (or at least mark it as @internal).Mar 31 2022, 3:32 PM
cscott added a subtask: T300979: Ensure ParserOutput can always be combined asynchronously/out-of-order.Mar 31 2022, 3:34 PM
cscott added a subtask: T296345: Add ParserOutput::addOutputData() to unify various accumulators in ParserOutput.
cscott added a subtask: T296352: ParserOutput::addWarningMsg() should take a MessageValue instead of a string.
cscott mentioned this in T287216: ParserOutput should implement ContentMetadataCollector.Mar 31 2022, 3:42 PM
ssastry moved this task from Needs Triage to Testing on the Parsoid board.Apr 12 2022, 7:08 AM
cscott added a parent task: T310512: Parsoid and the legacy parser should emit exactly the same ParserOutput metadata.Jun 13 2022, 4:45 PM
matmarex closed subtask T296025: ParserOutput::setSections() should be more structured as Resolved.Jan 23 2023, 9:34 AM
cscott added a subtask: T351931: With parsoid categories are not shown.EditedDec 7 2023, 3:27 PM

T351931: With parsoid categories are not shown requires ParserOutput::setCategories() which I don't think is covered by a more-specific task (yet)

Actually, ContentMetadataCollector already has ::addCategory although it takes a string (db key) and we should probably let it use a LinkTarget now that it can do so.

We still need to just iterate over the categories we see and add them to the PO.

MSantos closed subtask T351931: With parsoid categories are not shown as Resolved.Mon, Apr 8, 3:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL