Don't set language-specific data attributes in IPInfo widget
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Tchanders
	Apr 1 2022, 11:27 AM

Description

Background

The IPInfo widget displays IP information using lists. Data attributes are added to list items to identify what type of IP information they are. One use-case is adding specific styling for different properties, e.g. removing list styling for "Real IP/Proxy" data: https://gerrit.wikimedia.org/g/mediawiki/extensions/IPInfo/+/4c51721c2703f189aac2d4a2d0d9ea34deb0865f/modules/ext.ipInfo/ipinfo.less#52

The data attribute should be language agnostic, however it is currently being set to an English translation. An example bug is that the list styling is not removed for the real/proxy data if the language is not English:

English	French

Acceptance criteria

Set the data attribute to some string instead of an English translation
Also check this string when logging which help icon was clicked on, instead of re-translating a message here.

Notes

This might require passing a type string into ipInfoWidget#generatePropertyMarkup, where the data attribute is set, rather than passing in a message translation. See: https://gerrit.wikimedia.org/g/mediawiki/extensions/IPInfo/+/4c51721c2703f189aac2d4a2d0d9ea34deb0865f/modules/ext.ipInfo/widget.js#122

Details

	Subject	Repo	Branch	Lines +/-
	Pass a hardcoded property key for use in the data attribute	mediawiki/extensions/IPInfo	master	+24 -17

Customize query in gerrit

Related Objects

Mentioned Here: rEIPI090d340254d9: Localisation updates from https://translatewiki.net.

Event Timeline

Tchanders created this task.Apr 1 2022, 11:27 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2022, 11:27 AM

Tchanders moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Apr 5 2022, 2:46 PM

Tchanders updated the task description. (Show Details)Apr 5 2022, 2:59 PM

• AGueyte set the point value for this task to 1.Apr 11 2022, 3:27 PM

• AGueyte moved this task from Triage/To be Estimated to AHaT Sprint 5: The Bearskin on the Anti-Harassment board.Apr 11 2022, 3:33 PM

• AGueyte edited projects, added Anti-Harassment (AHaT Sprint 5: The Bearskin); removed Anti-Harassment.

STran claimed this task.Apr 11 2022, 7:23 PM

STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 5: The Bearskin) board.

Change 779135 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/IPInfo@master] Pass a hardcoded property key for use in the data attribute

https://gerrit.wikimedia.org/r/779135

gerritbot added a project: Patch-For-Review.Apr 11 2022, 10:00 PM

STran moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 5: The Bearskin) board.Apr 11 2022, 10:03 PM

• AGueyte moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 5: The Bearskin) board.Apr 13 2022, 7:52 PM

Change 779135 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Pass a hardcoded property key for use in the data attribute

https://gerrit.wikimedia.org/r/779135

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.8; 2022-04-18).Apr 13 2022, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 13 2022, 8:29 PM

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 6: The Bigouden); removed Anti-Harassment (AHaT Sprint 5: The Bearskin).Apr 19 2022, 4:16 PM

ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 6: The Bigouden) board.Apr 19 2022, 4:18 PM

I compared the HTML of the infobox and the popup in 2-3 different languages. The HTML markup (attributes, data-properties, etc.) was always the same.

I also checked that the infobox help popups still work.

I cannot reproduce the bug in the description when looking at the infobox in French:

french_proxytype.png (206×279 px, 12 KB)

Test environment: https://test.wikipedia.org IP Info 0.0.0 (090d340) 08:06, 18 April 2022.

• Niharika closed this task as Resolved.May 17 2022, 5:23 PM

• Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:58 PM

	F35059556: french_proxytype.png
	Apr 20 2022, 9:58 AM

Don't set language-specific data attributes in IPInfo widgetClosed, ResolvedPublic1 Estimated Story PointsActions