Page MenuHomePhabricator

External ID statement sometimes unformatted right after closing the edit interface
Open, Needs TriagePublicBUG REPORT

Description

Steps to reproduce

  1. Open https://www.wikidata.org/wiki/Q1030325#P10559
  2. Notice that it links to https://www.ksh.hu/apps/hntr.tortenet?p_lang=EN&p_id=52132
  3. Open the named statement for editing.
  4. Modify its value (e.g. insert a trailing space).
  5. Click Cancel.

Actual result

  1. The snak is no longer linked.

Expected result

  1. The snak continues to link to the same web page.

Additional information

P10559 has two formatter URLs, one of which is set to preferred. It looks like the PHP code correctly handles this situation, but the JS doesn’t. (I hope that setting preferred won’t be necessary after T259801, but it seemed that this makes the PHP fomatter happy.)

Event Timeline

I can’t reproduce this so far, the statement becomes a link again after cancelling (and also returns to the original value even when the modification in step 4 was a visible one, e.g. deleting a character).

I can’t reproduce it now either, even though I could consistently reproduce it yesterday. Maybe a such state got stuck in some cache where both formatters had the same rank? It’d be a bit surprising, though, as I changed the rank on Saturday, then turned off my computer completely, and I noticed this bug on Sunday. (Although I’ve set Firefox to remember my session, which may keep some caches alive.)