Page MenuHomePhabricator
Create Task
Maniphest T305340

Make user_editcount field unsigned
Closed, ResolvedPublic
Actions

Description

It should be impossible to have a negative number of edits.
Inspired by T305329 where there was such a negative edit count, which has been fixed - per T305329#7827210 there should be no other such negative numbers on any wiki, so it should be safe to change to unsigned

Details

SubjectRepoBranchLines +/-
Schema:Updating user_editcount field to unsignedmediawiki/coremaster+333 -5
Schema: Updating user_editcount field to unsignedmediawiki/coremaster+205 -3
Updating user_editcount field to unsignedmediawiki/coremaster+2 K -413
Updating user_editcount field to unsignedmediawiki/coremaster+318 -4
Updating user_editcount field to unsignedmediawiki/coremaster+321 -3
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Apr 4 2022, 4:22 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptApr 4 2022, 4:22 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Diesel_kapasule subscribed.Apr 4 2022, 8:33 AM

Hi guys, can I have steps to reproduce this bug!

Aklapper added a comment.Apr 4 2022, 8:44 AM

@Diesel_kapasule: Hi, can you please describe what you've tried already and what exactly is unclear and why? There's not much to reproduce here, this is about the database scheme of MediaWiki core. (PS: Please also see https://www.mediawiki.org/wiki/Inclusive_language ) Thanks!

Diesel_kapasule changed the task status from Open to In Progress.Apr 4 2022, 2:29 PM
Diesel_kapasule claimed this task.
gerritbot added a comment.Apr 4 2022, 4:34 PM

Change 776970 had a related patch set uploaded (by Diesel kapasule; author: Diesel kapasule):

[mediawiki/core@master] Updating user_editcount field to unsigned

https://gerrit.wikimedia.org/r/776970

gerritbot added a project: Patch-For-Review.Apr 4 2022, 4:34 PM
Zabe moved this task from Unsorted to Change on the Schema-change board.Apr 14 2022, 12:10 AM
gerritbot added a comment.Apr 14 2022, 6:40 PM

Change 776970 abandoned by Diesel kapasule:

[mediawiki/core@master] Updating user_editcount field to unsigned

Reason:

Merge Conflict

https://gerrit.wikimedia.org/r/776970

gerritbot added a comment.Apr 14 2022, 6:54 PM

Change 780974 had a related patch set uploaded (by Diesel kapasule; author: Diesel kapasule):

[mediawiki/core@master] Updating user_editcount field to unsigned

https://gerrit.wikimedia.org/r/780974

gerritbot added a comment.Apr 14 2022, 7:23 PM

Change 776970 restored by Diesel kapasule:

[mediawiki/core@master] Updating user_editcount field to unsigned

https://gerrit.wikimedia.org/r/776970

gerritbot added a comment.Apr 14 2022, 7:24 PM

Change 780974 abandoned by Diesel kapasule:

[mediawiki/core@master] Updating user_editcount field to unsigned

Reason:

Merge conflict

https://gerrit.wikimedia.org/r/780974

gerritbot added a comment.Apr 15 2022, 11:59 AM

Change 780974 restored by Diesel kapasule:

[mediawiki/core@master] Updating user_editcount field to unsigned

https://gerrit.wikimedia.org/r/780974

gerritbot added a comment.Apr 15 2022, 12:00 PM

Change 776970 abandoned by Diesel kapasule:

[mediawiki/core@master] Updating user_editcount field to unsigned

Reason:

Merge conflict

https://gerrit.wikimedia.org/r/776970

gerritbot added a comment.Apr 15 2022, 12:13 PM

Change 780974 abandoned by Diesel kapasule:

[mediawiki/core@master] Updating user_editcount field to unsigned

Reason:

https://gerrit.wikimedia.org/r/780974

gerritbot added a comment.Apr 15 2022, 12:15 PM

Change 782011 had a related patch set uploaded (by Diesel kapasule; author: Diesel kapasule):

[mediawiki/core@master] Updating user_editcount field to unsigned

https://gerrit.wikimedia.org/r/782011

gerritbot added a comment.Apr 15 2022, 12:26 PM

Change 780974 restored by Diesel kapasule:

[mediawiki/core@master] Updating user_editcount field to unsigned

https://gerrit.wikimedia.org/r/780974

gerritbot added a comment.Apr 15 2022, 12:26 PM

Change 780974 abandoned by Diesel kapasule:

[mediawiki/core@master] Updating user_editcount field to unsigned

Reason:

https://gerrit.wikimedia.org/r/780974

gerritbot added a comment.Apr 15 2022, 12:26 PM

Change 776970 restored by Diesel kapasule:

[mediawiki/core@master] Updating user_editcount field to unsigned

https://gerrit.wikimedia.org/r/776970

gerritbot added a comment.Apr 15 2022, 12:26 PM

Change 782011 abandoned by Diesel kapasule:

[mediawiki/core@master] Updating user_editcount field to unsigned

Reason:

https://gerrit.wikimedia.org/r/782011

gerritbot added a comment.Apr 18 2022, 8:23 AM

Change 776970 abandoned by Diesel kapasule:

[mediawiki/core@master] Updating user_editcount field to unsigned

Reason:

https://gerrit.wikimedia.org/r/776970

gerritbot added a comment.Apr 18 2022, 9:24 AM

Change 783825 had a related patch set uploaded (by Diesel kapasule; author: Diesel kapasule):

[mediawiki/core@master] Schema:Updating user_editcount field to unsigned

https://gerrit.wikimedia.org/r/783825

gerritbot added a comment.Apr 21 2022, 9:17 AM

Change 785123 had a related patch set uploaded (by Diesel kapasule; author: Diesel kapasule):

[mediawiki/core@master] Schema:Updating user_editcount field to unsigned

https://gerrit.wikimedia.org/r/785123

gerritbot added a comment.May 9 2022, 9:50 PM

Change 785123 merged by jenkins-bot:

[mediawiki/core@master] Schema: Updating user_editcount field to unsigned

https://gerrit.wikimedia.org/r/785123

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 9 2022, 10:00 PM
gerritbot added a comment.May 9 2022, 10:18 PM

Change 783825 abandoned by Zabe:

[mediawiki/core@master] Schema:Updating user_editcount field to unsigned

Reason:

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/785123

https://gerrit.wikimedia.org/r/783825

Diesel_kapasule closed this task as Resolved.May 10 2022, 6:27 AM
Ladsgroup subscribed.May 20 2022, 3:41 PM

You need to create a schema change ticket in production as well... https://wikitech.wikimedia.org/wiki/Schema_changes#Workflow_of_a_schema_change

Ladsgroup reopened this task as Open.May 20 2022, 3:42 PM
Ladsgroup added a subscriber: MNadrofsky.May 26 2022, 1:27 PM

@MNadrofsky This is not the first time S&F just half done tickets (and unresponsive to pings). I finish it but this is not sustainable.

Ladsgroup closed this task as Resolved.May 26 2022, 1:35 PM

T309311: Make user_editcount unsigned in production

MNadrofsky added a comment.EditedMay 26 2022, 3:15 PM
In T305340#7960425, @Ladsgroup wrote:

@MNadrofsky This is not the first time S&F just half done tickets (and unresponsive to pings). I finish it but this is not sustainable.

Thank you for your work and for posting this. I'll follow up directly with S&F and share this ticket with them for comment/feedback.

Ladsgroup added a comment.May 26 2022, 4:19 PM

Thanks

Ladsgroup mentioned this in T309311: Make user_editcount unsigned in production.May 27 2022, 3:55 PM
LSobanski subscribed.May 30 2022, 11:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL