Page MenuHomePhabricator

Newcomer tasks: deploy AND selection to all wikis
Open, In Progress, Needs TriagePublic

Description

In T305399, we deployed AND selection to the pilot wikis. After two weeks of data collection, we will have done data analysis in T305406. If we don't see any issues from the data analysis or hear any from our communities, then we'll deploy to all users on all wikis in this task.

Event Timeline

Sgs changed the task status from Stalled to In Progress.Jun 28 2022, 11:36 AM
Sgs claimed this task.
Sgs removed Sgs as the assignee of this task.

Change 830202 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[operations/mediawiki-config@master] Enable the topic match mode in all wikis

https://gerrit.wikimedia.org/r/830202

@KieranMcCann do we need a different icon state on the Topic filter to show the user that their topic filter is in AND mode?

Compare AND mode:

image.png (1×1 px, 302 KB)

to OR mode:

image.png (1×1 px, 107 KB)

As a user, my only visual cue is that the total count is increased.

Reviewing the designs, I think there's already a "hint" icon for the mode (+ sign). At least in mobile design I can see "GLAM Argentina +", although I think a real examples would show "3 Topics +". Checking on the deployed version it's not showing for me.

image.png (3×3 px, 662 KB)

From T301825: Account creation: add toggle to enable AND selection of interest topics

Maybe we can fix this bug for mobile and apply the same solution for desktop? One thing that bothers me with "3 Topics +" is that it can be read as "more than 3 topics" rather than "3 matching topics". What do you think? @KieranMcCann

Reviewing the designs, I think there's already a "hint" icon for the mode (+ sign). At least in mobile design I can see "GLAM Argentina +", although I think a real examples would show "3 Topics +". Checking on the deployed version it's not showing for me.

image.png (3×3 px, 662 KB)

From T301825: Account creation: add toggle to enable AND selection of interest topics

Maybe we can fix this bug for mobile and apply the same solution for desktop? One thing that bothers me with "3 Topics +" is that it can be read as "more than 3 topics" rather than "3 matching topics". What do you think? @KieranMcCann

Ah, right. Yeah, it's specific to when there are more than 2 topics selected.

I was thinking that perhaps there is a way to combine the topic icon with a + sign

image.png (88×96 px, 2 KB)

Hi @kostajh @Sgs. Yep I can see how this is a bit tricky. I don’t think either adding the plus sign to the ‘# topics’ text or to the icon will be particularly clear for users.

I would read ‘3 topics +’ as meaning more than three topics, as you pointed out Sergio.

I’m not sure I would create a new icon for this purpose either, and also I think I would read that as ‘add filters’ rather than representing the filter mode.

I wonder if adding the filter mode in parenthesis after the number of topics might be a better solution? Though this may have to be shorted on mobile to fit. Here is what I mean...

Screenshot 2022-09-15 at 13.45.07.png (518×3 px, 112 KB)

I wonder if adding the filter mode in parenthesis after the number of topics might be a better solution? Though this may have to be shorted on mobile to fit. Here is what I mean...

Characterizing AND/OR relationships is somewhat hard. Does "ALL" mean the tasks must match all three topics, or that we match all tasks that belong in these topics?
Then again, the dropdown is clear so not sure if this view has to be.

I wonder if adding the filter mode in parenthesis after the number of topics might be a better solution? Though this may have to be shorted on mobile to fit. Here is what I mean...

Characterizing AND/OR relationships is somewhat hard. Does "ALL" mean the tasks must match all three topics, or that we match all tasks that belong in these topics?
Then again, the dropdown is clear so not sure if this view has to be.

I agree that the dropdown instructions are clear; perhaps if there was an icon associated with each option in the dropdown in the Topics dialog, and we displayed that icon on the Suggested Edits module next to the topic selection indicator, that would provide enough of a visual cue to the user to remember what is going on with the topics.

I agree that the dropdown instructions are clear; perhaps if there was an icon associated with each option in the dropdown in the Topics dialog, and we displayed that icon on the Suggested Edits module next to the topic selection indicator, that would provide enough of a visual cue to the user to remember what is going on with the topics.

I’ve mocked up what it would look like to create an icon modifier for the ‘match all’ option and add it to the buttons and drop down. I still have my reservations over whether this makes it clearer but let me know if you think this is better/clearer.

Screenshot 2022-09-20 at 10.41.08.png (2×3 px, 625 KB)

I agree that the dropdown instructions are clear; perhaps if there was an icon associated with each option in the dropdown in the Topics dialog, and we displayed that icon on the Suggested Edits module next to the topic selection indicator, that would provide enough of a visual cue to the user to remember what is going on with the topics.

I’ve mocked up what it would look like to create an icon modifier for the ‘match all’ option and add it to the buttons and drop down. I still have my reservations over whether this makes it clearer but let me know if you think this is better/clearer.

Screenshot 2022-09-20 at 10.41.08.png (2×3 px, 625 KB)

Thanks. I also have reservations, but it seems better than having no indicator, IMO.

I agree on the fact that it looks better than having no indicator.

As we have a + for ALL, can we have an icon for ANY? for instance? This way we can reuse it on the task selection card to show which selection was made.

Are we changing the sentences for the filters? If I'm not wrong, at the moment it is

  • MediaWiki:Growthexperiments-homepage-suggestededits-topics-match-mode-any ("Match at least one selected topic")
  • MediaWiki:Growthexperiments-homepage-suggestededits-topics-match-mode-all ("Match all selected topics").

If we use them, I have some reservations regarding how "Match ANY" and "Match ALL" will look with a longer text and caps, especially on mobile. I use French as an an example, and I built the sentence using source based translators to have something that matches most translations:

  • Match ANY -> [Correspond à] N'IMPORTE QUEL terme
  • Match ALL -> [Correspond à] TOUS les termes

Brackets are here for parts of the sentence that can be omitted but should be included for clarity. Bu tit is still long for a narrow display.