Page MenuHomePhabricator

Account creation: remove GLAM event ad-hoc code after 20th of April
Closed, ResolvedPublic

Description

Given the deadline constraints we had for the GLAM events (see parent task) we have introduced some hard-coded and ad-hoc lines of code that we would like to get rid of after Chile's event.

We added the code comment // FIXME remove when GLAM campaign is over to signal this. There are at least 5 of these and we should do a broad lookup for the term "GLAM" to make sure we don't leave crumbs behind.

Event Timeline

MMiller_WMF renamed this task from Account creation: remove GLAM event ad-hoc code after 14th of April to Account creation: remove GLAM event ad-hoc code after 20th of April.Apr 11 2022, 5:25 AM

@Sgs -- it seems that the date of the Wikimedia Chile has changed to April 20, so I changed the title of the task.

We identified some "nice to have" features for campaign configuration that we already applied to GLAM campaigns. Instead of removing the logic that backs it for GLAM campaigns we can adapt the code so this configurations are available for any existing and upcoming campaigns.

The break down is:

  • Skip the welcome survey: by default campaigns will show the survey. A config property skipWelcomeSurvey in campaigns config set to true will make the campaign account creation process skip the survey.
  • Quality gate config: by default campaigns will apply the on-wiki configured quality gates. A config property skipImageRecommendationDailyTaskLimit in campaigns config set to true will make the campaign account created skip the quality gate for the images daily limit. (This seems too specific to GLAM campaigns, maybe we would want to generalize to have a full quality gate config object? However this would require extra development, the skipImageRecommendationDailyTaskLimit is pretty easy since the image recommendation check is already receiving the campaigns configuration)
  • Extra topics: By default campaigns will not have extra topics shown. An existing config property topics in campaigns config set to 'topics' => [ 'argentina', 'mexico' ] will make the campaign account created show the extra configured topics in the collection of topics to filter.

@MMiller_WMF can you confirm the requirements are correctly described as we discussed? Should we re-word the task title?

Change 780862 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Account creation: allow campaigns to skip the welcome survey based in config

https://gerrit.wikimedia.org/r/780862

Change 780863 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Account creation: allow campaigns to skip the image recommendation daily limit quality gate

https://gerrit.wikimedia.org/r/780863

Change 780864 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Account creation: remove FIXME comment

https://gerrit.wikimedia.org/r/780864

Sgs changed the task status from Open to In Progress.Apr 14 2022, 5:41 PM
Sgs claimed this task.
Sgs moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
Sgs moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 790650 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[operations/mediawiki-config@master] Account creation: update live campaigns config

https://gerrit.wikimedia.org/r/790650

Change 780863 abandoned by Sergio Gimeno:

[mediawiki/extensions/GrowthExperiments@master] Account creation: allow campaigns to skip the image recommendation daily limit quality gate

Reason:

Squashed into https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/780862

https://gerrit.wikimedia.org/r/780863

Change 780864 abandoned by Sergio Gimeno:

[mediawiki/extensions/GrowthExperiments@master] Account creation: remove FIXME comment

Reason:

Squashed into https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/780862

https://gerrit.wikimedia.org/r/780864

kostajh triaged this task as Medium priority.May 12 2022, 8:58 AM

Patchset 23 with the following config led to some unexpected UIs.

	'social-latam-2022-A' => [
		'skipWelcomeSurvey' => true,
		'pattern' => '/^social-latam-2022-A$/'
	]
MobileDesktop
Screen Shot 2022-05-12 at 12.57.44 PM.png (1×756 px, 466 KB)
Screen Shot 2022-05-12 at 12.59.02 PM.png (1×1 px, 829 KB)

Change 790650 merged by jenkins-bot:

[operations/mediawiki-config@master] GrowthExperiments: Update campaigns configuration

https://gerrit.wikimedia.org/r/790650

Mentioned in SAL (#wikimedia-operations) [2022-05-16T07:54:21Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: e9a00e8: GrowthExperiments: Update campaigns configuration (T305443, T305659, T307521) (duration: 00m 50s)

Change 780862 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Account creation: allow campaign configuration via GECampaigns option

https://gerrit.wikimedia.org/r/780862