A test like "argument name error: misnamed argument" (test/features/v1/mswOrchestrateTest.js) will fail if the composition is Z881 instead of Z882. This means that we are inappropriately skipping normal function execution in cases where the builtin list is not part of the function call's internals (possibly because doValidate=false was set too aggressively somewhere).
A good test for this fix would be to replicate the "misnamed argument" test but using Z881, not Z882, in the composition.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Resolve internals when resolving implementations. | mediawiki/services/function-orchestrator | master | +71 -2 |
Change 782647 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):
[mediawiki/services/function-orchestrator@master] Do not resolve compositions early since they will be resolved during implementation execution.
Change 782647 merged by jenkins-bot:
[mediawiki/services/function-orchestrator@master] Resolve internals when resolving implementations.
This is also causing a warning to surface from convertZListToArray; this is because we create a schema for typed lists whose types we don't resolve.