Page MenuHomePhabricator

Verify Growth editing workflows on mobile
Closed, ResolvedPublic

Description

When T219420: Update page dynamically after save on mobile is completed, the page will no longer be reloaded after an edit is complete. That might require some changes on GrowthExperiments Add-Link or Image-Suggestions VE plugins which assume that the page is reloaded on mobile.

The changes should be merged in the same train as T219420: Update page dynamically after save on mobile

Acceptance criteria
  • For unstructured task edits made with VisualEditor, the post-edit dialog shows up without a page reload.
  • For unstructured task edits made with the source editor, the post-edit dialog shows up after a page reload.
  • For structured task edits, the post-edit dialog shows up after a page reload.

Event Timeline

With T301603: Newcomer tasks: increased flexibility at post-edit dialog, the page is reloaded for structured tasks for both desktop and mobile after an edit is made in order to set up the regular article target since the tools and keyboard shortcuts are de-registered).

Once T219420: Update page dynamically after save on mobile in place, we will need to make the following changes to show the post-edit dialog on mobile.

Task typeCurrentChanges required
UnstructuredpostEditMobile shows the post-edit dialog after the next reload that occurs after the event is firedShow the post-edit dialog in the current session; make sure that when the user edits the same article again, the post-edit dialog is shown
StructuredSame as unstructured tasksIn the short term, force a reload before showing the post-edit dialog (same as desktop) in order to get rid of StructuredTaskArticleTarget. In the longer term, update the article target without reloading (T308046).

Change 790730 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Change how the post-edit dialog is shown on mobile

https://gerrit.wikimedia.org/r/790730

Here are the screen recordings of the flows with VE, MobileFrontEnd and GrowthExperiments patches (click to open animated GIF):

CopyeditCopyedit (source)Add image (acceptance)Add image (rejection)
posteditMobile_copyedit.gif (1×748 px, 2 MB)
source_copyedit.gif (1×748 px, 1 MB)
posteditMobile_addImage_accepted.gif (1×748 px, 2 MB)
posteditMobile_addimage_rejected.gif (1×748 px, 1 MB)

Hi @ppelberg, I have posted a patch to make our features compatible with the latest VE changes. I think it would make sense for us to co-ordinate to make sure that the GrowthExperiments patch goes into the same train as the VE changes (otherwise our post-edit functionality would break). Is there a release date yet for the changes on your end?

cc: @DMburugu @MShilova_WMF

I think it would make sense for us to co-ordinate to make sure that the GrowthExperiments patch goes into the same train as the VE changes (otherwise our post-edit functionality would break).

@mewoph: +1 to the idea you raised of coordinating the deployment of the GrowthExperiments and VE patches to ensure they ride the same train.

Is there a release date yet for the changes on your end?

Yep – the Editing Team is planning to deploy T219420's remaining patches on the train that is scheduled to begin rolling out on Tuesday, 24 May 2022. [i]

I've added the 24 May deployment timing to T219420's task description. Should that timing change, we'll update the task.

And of course, if anything about the above presents challenges for y'all, please let me know.


i. Note: We are planning to merge these patches on Tuesday, 17 May 2022, so that Editing has sufficient time to QA these changes before they land in production.

mewoph set Due Date to May 17 2022, 7:00 AM.May 11 2022, 11:08 PM
mewoph updated the task description. (Show Details)

I think it would make sense for us to co-ordinate to make sure that the GrowthExperiments patch goes into the same train as the VE changes (otherwise our post-edit functionality would break).

@mewoph: +1 to the idea you raised of coordinating the deployment of the GrowthExperiments and VE patches to ensure they ride the same train.

Is there a release date yet for the changes on your end?

Yep – the Editing Team is planning to deploy T219420's remaining patches on the train that is scheduled to begin rolling out on Tuesday, 24 May 2022. [i]

I've added the 24 May deployment timing to T219420's task description. Should that timing change, we'll update the task.

And of course, if anything about the above presents challenges for y'all, please let me know.


i. Note: We are planning to merge these patches on Tuesday, 17 May 2022, so that Editing has sufficient time to QA these changes before they land in production.

I've +2'ed I've not yet +2'ed the GrowthExperiments patch, but theoretically it will merge at the same time as the VE and MobileFrontend ones with the Depends-On glue, assuming no rebase problems occur.

Change 790730 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Change how the post-edit dialog is shown on mobile

https://gerrit.wikimedia.org/r/790730

@mewoph - after testing on beta, I filed T309068: [betalabs-mobile] Publishing edits from source editor re-opens page in editing mode for the following case: a non-Structured edit is in the source editor (it could be a known issue). The issue is directly affecting displaying the post-edit dialog functionality (the screen recording is below).

source_editor.gif (702×351 px, 780 KB)