Page MenuHomePhabricator
Create Task
Maniphest T30556

UploadBase::checkMacBinary should be removed
Closed, ResolvedPublic
Actions

Description

Author: neilk

Description:
In UploadBase::checkMacBinary, if a file is discovered to have MacBinary encoding, a new file is created from the data fork, and the upload is modified so its mTempPath now points to this new file.

This doesn't use the FileRepo abstractions for temporary file storage, and it should. Otherwise this will be a problem for some new network file storage implementations which aren't mounted on the filesystem.

Version: unspecified
Severity: normal

Details

Reference
bz28556

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:28 PM
• bzimport added a project: MediaWiki-File-management.
• bzimport set Reference to bz28556.
• bzimport created this task.Apr 15 2011, 6:10 PM
• bzimport added a comment.Apr 22 2011, 6:32 PM

Bryan.TongMinh wrote:

This is a left over of Internet Explorer for Mac. As far as I know modern Mac browsers are not using MacBinaries. We could just kill it.

• brooke added a comment.Jun 6 2011, 11:32 PM

I would not object to removing it at this point. IE 5 for Mac was the only known user of this code, and it's so broken nothing works with it anymore hardly. ;)

MarkAHershberger added a comment.Jun 7 2011, 2:23 AM

fixed summary, assigned to self.

Krinkle added a comment.Jun 13 2011, 7:01 PM

Fixed in r89995.

• Gilles added a project: Multimedia.Dec 4 2014, 10:29 AM
• Gilles moved this task from Untriaged to Done on the Multimedia board.Dec 4 2014, 10:41 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits