Page MenuHomePhabricator
Create Task
Maniphest T305560

Remove Skin::getCopyrightIcon and Skin::getPoweredBy
Closed, ResolvedPublic
Actions

Description

Deprecated in 1.37. Both can safely be removed.

https://codesearch.wmcloud.org/search/?q=getCopyrightIcon&i=nope&files=&excludeFiles=&repos=
https://codesearch.wmcloud.org/search/?q=getPoweredBy&i=nope&files=&excludeFiles=&repos=

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
skins: Remove used deprecated Skin::class methodsD3r1ck01mediawiki/coremaster+2 -21
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Apr 6 2022, 3:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2022, 3:58 PM
gerritbot added a comment.Apr 13 2022, 4:36 PM

Change 779913 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] skins: Remove used deprecated Skin::class methods

https://gerrit.wikimedia.org/r/779913

gerritbot added a project: Patch-For-Review.Apr 13 2022, 4:36 PM
Jdlrobson mentioned this in T306138: Remove poweredbyico SkinTemplate variable AND SkinGetPoweredBy hook.Apr 13 2022, 9:52 PM
gerritbot added a comment.Apr 13 2022, 10:08 PM

Change 779913 merged by jenkins-bot:

[mediawiki/core@master] skins: Remove used deprecated Skin::class methods

https://gerrit.wikimedia.org/r/779913

Maintenance_bot removed a project: Patch-For-Review.Apr 13 2022, 10:30 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.8; 2022-04-18).Apr 13 2022, 11:00 PM
xSavitar closed this task as Resolved.Apr 14 2022, 11:53 AM
xSavitar claimed this task.
Restricted Application added a project: User-xSavitar. · View Herald TranscriptApr 14 2022, 11:53 AM
Jdlrobson edited projects, added: Patch-For-Review, Web-Team-Backlog-Archived (Kanbanana-FY-2021-22); removed: User-xSavitar, MW-1.39-notes (1.39.0-wmf.8; 2022-04-18).Apr 14 2022, 5:21 PM

Thank you!

Restricted Application added a project: User-xSavitar. · View Herald TranscriptApr 14 2022, 5:21 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits