Page MenuHomePhabricator
Create Task
Maniphest T305612

WikiLambda: Translate "not connected" errors from FunctionCall and PerformTest APIs into ZErrors
Closed, ResolvedPublic
Actions

Description

When there's a connection error, the returned value is "apierror-wikilambda_function_call-not-connected". We should translate this into a ZErrorType built-in and a Z5 error

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
wikifunctions: Upgrade orchestrator from 2025-11-08-223341 to 2025-11-18-175356operations/deployment-chartsmaster+1 -1
Return Z529/Connection error in other applicable instancesmediawiki/extensions/WikiLambdamaster+9 -23
Translate connection errors to ZErrorType built-in and Z5 errorsmediawiki/extensions/WikiLambdamaster+22 -4
Update function-schemata sub-module to HEAD (91e3ffe)mediawiki/extensions/WikiLambdamaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

gengh created this task.Apr 7 2022, 8:20 AM
Jdforrester-WMF moved this task from To Triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Apr 19 2022, 4:16 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Nice-to-haves on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:46 PM
Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 7 2022, 5:35 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase κ – Clean-up).
Jdforrester-WMF triaged this task as Medium priority.Mar 24 2023, 1:07 AM
Jdforrester-WMF added a project: good first task.Jun 5 2023, 6:00 PM
Jdforrester-WMF lowered the priority of this task from Medium to Low.Feb 22 2024, 5:53 PM
Jdforrester-WMF moved this task from To triage: Nice-to-haves to To Triage on the Abstract Wikipedia team board.
Jdforrester-WMF moved this task from To Triage to Backlog on the Abstract Wikipedia team board.
Jdforrester-WMF moved this task from Backlog to Engineering Backlog on the Abstract Wikipedia team board.Nov 18 2024, 5:02 PM
Arpitajain28 subscribed.Oct 8 2025, 4:30 PM
gerritbot added a comment.Oct 8 2025, 7:43 PM

Change #1194726 had a related patch set uploaded (by Arpitajain28; author: Arpitajain28):

[mediawiki/extensions/WikiLambda@master] T305612: Translate connection errors to ZErrorType built-in and Z5 errors

https://gerrit.wikimedia.org/r/1194726

gerritbot added a project: Patch-For-Review.Oct 8 2025, 7:43 PM
Arpitajain28 added a comment.Oct 11 2025, 4:32 PM

I have subscribed your task and tried to resolve the issue mentioned in the description. You can check and tell me the changes required.

gengh added a comment.Oct 17 2025, 9:30 AM

Hello, @Arpitajain28! Thank you for your contribution!

We have recently merged significant changes in the files you worked on, so I rebased your patch on top of those changes.

Adding a new builtin ZError requires a bit more work; the existing builtin errors are in function-schemata/data/definitions (https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/tree/main/data/definitions) and should be added there first. You can see a table of the current errors in here, too: https://meta.wikimedia.org/wiki/Abstract_Wikipedia/Representation_of_errors

So, the next free slot should be Z576, but I'd suggest using the Z529 one, so that it's contiguous to Z530/Api error (which seems closely related).

The process to add an error would be:

  1. Add the new ZObject to function-schemata/data/definitions, and get it merged
  2. Once that is merged, we would update wikilambda reference of function-schemata in an isolated patch (like this one https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/1192975)
  3. Then, your patch could be merged (this would make sure that the object referred to i.e. Z529 exists as a built-in)

I can get function-schemata ready for your changes and follow-up in gerrit.

CodeReviewBot added a comment.Nov 10 2025, 11:44 AM

gengh opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/294

definitions: Add connection failure error type Z529

CodeReviewBot added a comment.Nov 10 2025, 2:45 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/294

definitions: Add connection failure error type Z529

gerritbot added a comment.Nov 10 2025, 9:16 PM

Change #1203549 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (5bf82a1)

https://gerrit.wikimedia.org/r/1203549

CodeReviewBot added a comment.Nov 12 2025, 4:45 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/94

Update function-schemata sub-module to HEAD (c92f78e)

CodeReviewBot added a comment.Nov 12 2025, 4:45 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/485

Update function-schemata sub-module to HEAD (c92f78e)

CodeReviewBot added a comment.Nov 12 2025, 4:46 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/443

Update function-schemata sub-module to HEAD (c92f78e)

Jdforrester-WMF mentioned this in rMSFEd743585100ab: Update function-schemata sub-module to HEAD (c92f78e).Nov 12 2025, 4:47 PM
CodeReviewBot added a comment.Nov 12 2025, 4:47 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/94

Update function-schemata sub-module to HEAD (c92f78e)

CodeReviewBot added a comment.Nov 14 2025, 2:25 AM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/485

Update function-schemata sub-module to HEAD (c92f78e)

CodeReviewBot added a comment.Nov 14 2025, 2:25 AM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/443

Update function-schemata sub-module to HEAD (c92f78e)

cmassaro mentioned this in rMSFEc59af7a008e7: Update function-schemata sub-module to HEAD (c92f78e).Nov 14 2025, 2:25 AM
gerritbot added a comment.Nov 14 2025, 9:41 PM

Change #1203549 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (91e3ffe)

https://gerrit.wikimedia.org/r/1203549

Jdforrester-WMF changed the task status from Open to In Progress.Nov 14 2025, 9:42 PM
Jdforrester-WMF added a parent task: T406345: [26Q2] Error advocacy.
Jdforrester-WMF edited projects, added Abstract Wikipedia team (26Q2 (Oct–Dec)); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Ready to deploy on the Abstract Wikipedia team (26Q2 (Oct–Dec)) board.
gerritbot added a comment.Nov 17 2025, 12:56 PM

Change #1194726 had a related patch set uploaded (by Genoveva Galarza; author: Arpitajain28):

[mediawiki/extensions/WikiLambda@master] Translate connection errors to ZErrorType built-in and Z5 errors

https://gerrit.wikimedia.org/r/1194726

gerritbot added a comment.Nov 18 2025, 9:47 AM

Change #1194726 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Translate connection errors to ZErrorType built-in and Z5 errors

https://gerrit.wikimedia.org/r/1194726

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.4; 2025-11-25).Nov 18 2025, 4:01 PM
gerritbot added a comment.Nov 18 2025, 4:52 PM

Change #1206919 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Return Z529/Connection error in other applicable instances

https://gerrit.wikimedia.org/r/1206919

gerritbot added a comment.Nov 18 2025, 5:49 PM

Change #1206919 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Return Z529/Connection error in other applicable instances

https://gerrit.wikimedia.org/r/1206919

gerritbot added a comment.Nov 18 2025, 11:43 PM

Change #1206981 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-11-08-223341 to 2025-11-18-175356

https://gerrit.wikimedia.org/r/1206981

gerritbot added a comment.Nov 19 2025, 3:38 PM

Change #1206981 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-11-08-223341 to 2025-11-18-175356

https://gerrit.wikimedia.org/r/1206981

gengh assigned this task to Arpitajain28.Nov 20 2025, 10:03 AM
gengh closed this task as Resolved.Nov 26 2025, 4:41 PM
gerritbot added a comment.Nov 27 2025, 1:14 AM

Change #1211872 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2025-11-12-122736 to 2025-11-17-175029

https://gerrit.wikimedia.org/r/1211872

Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (26Q2 (Oct–Dec)) board.Dec 8 2025, 7:31 PM
DSantamaria added a project: Essential-Work.Dec 9 2025, 6:42 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits