Page MenuHomePhabricator
Create Task
Maniphest T305623

Links with anchors are not rendered when the anchor is the same as the text
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Create a page with [[Hello#World|World]];
  • Save the page.

What happens?:
No link is rendered.

What should have happened instead?:
The link is rendered.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
MediaWiki 1.35.6 with DisplayTitle 3.1 (5949476). This is probably related to T297930. From my testing, it seems to happen only when the anchor text is the same as the link text.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/DisplayTitleREL1_39+5 -4Do not remove fragments if not proper part of text
mediawiki/extensions/DisplayTitleREL1_38+5 -4Do not remove fragments if not proper part of text
mediawiki/extensions/DisplayTitleREL1_35+5 -4Do not remove fragments if not proper part of text
mediawiki/extensions/DisplayTitlemaster+12 -2Add config $wgDisplayTitleAnonSmwSubobjects
mediawiki/extensions/DisplayTitlemaster+5 -4Do not remove fragments if not proper part of text
Customize query in gerrit

Related Objects

Event Timeline

Xxmarijnw created this task.Apr 7 2022, 11:45 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 7 2022, 11:45 AM
Xxmarijnw mentioned this in T309051: DisplayTitle shows nothing when linking to an anchor on a page with the same display as its anchor.Jun 27 2022, 4:14 PM
gerritbot added a comment.Jul 4 2022, 4:10 AM

Change 810553 had a related patch set uploaded (by RheingoldRiver; author: RheingoldRiver):

[mediawiki/extensions/DisplayTitle@master] Add config $wgDisplayTitleAnonSmwSubobjects

https://gerrit.wikimedia.org/r/810553

gerritbot added a project: Patch-For-Review.Jul 4 2022, 4:10 AM
RheingoldRiver merged a task: T309051: DisplayTitle shows nothing when linking to an anchor on a page with the same display as its anchor.Jul 4 2022, 4:11 AM
RheingoldRiver added subscribers: RheingoldRiver, Schtom.
Kirrus added a subscriber: Kirrus.Nov 1 2022, 1:58 PM
MeneerWout added a subscriber: MeneerWout.Nov 14 2022, 1:21 PM

Fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DisplayTitle/+/856547 please merge

freephile added a subscriber: freephile.Dec 22 2022, 5:35 AM
gerritbot added a comment.Dec 23 2022, 10:04 AM

Change 856547 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: WgevaertWikiBase):

[mediawiki/extensions/DisplayTitle@REL1_35] Do not remove fragments if not proper part of text

https://gerrit.wikimedia.org/r/856547

gerritbot added a comment.Dec 23 2022, 10:42 AM

Change 871136 had a related patch set uploaded (by WgevaertWikiBase; author: WgevaertWikiBase):

[mediawiki/extensions/DisplayTitle@master] Do not remove fragments if not proper part of text

https://gerrit.wikimedia.org/r/871136

gerritbot added a comment.Jan 11 2023, 12:18 AM

Change 871136 merged by jenkins-bot:

[mediawiki/extensions/DisplayTitle@master] Do not remove fragments if not proper part of text

https://gerrit.wikimedia.org/r/871136

CCicalese_WMF mentioned this in rEDPT10e1f29dd5e9: Do not remove fragments if not proper part of text.Jan 11 2023, 12:19 AM
gerritbot added a comment.Jan 11 2023, 12:24 AM

Change 810553 abandoned by Cicalese:

[mediawiki/extensions/DisplayTitle@master] Add config $wgDisplayTitleAnonSmwSubobjects

Reason:

I don't believe this is required anymore, since the bug was fixed in Ib37882c1.

https://gerrit.wikimedia.org/r/810553

gerritbot added a comment.Jan 11 2023, 12:41 AM

Change 856547 merged by jenkins-bot:

[mediawiki/extensions/DisplayTitle@REL1_35] Do not remove fragments if not proper part of text

https://gerrit.wikimedia.org/r/856547

thiemowmde mentioned this in rEDPTbc115561369f: Do not remove fragments if not proper part of text.Jan 11 2023, 12:43 AM
Maintenance_bot removed a project: Patch-For-Review.Jan 11 2023, 1:30 AM
cicalese closed this task as Resolved.Jan 11 2023, 2:39 AM
cicalese claimed this task.

The bug is fixed by the referenced patches. Links are no longer invisible when the link text matches the link fragment, and the link text is not truncated when it ends with the fragment. However, unit tests should be introduced to guard against this behavior being reintroduced. And, there are still open questions about what the link text should be for links that have fragments. I have opened T326700 to track that investigation.

freephile awarded a token.Jan 25 2023, 1:38 PM
gerritbot added a comment.Feb 5 2023, 2:07 PM

Change 886419 had a related patch set uploaded (by Cicalese; author: WgevaertWikiBase):

[mediawiki/extensions/DisplayTitle@REL1_38] Do not remove fragments if not proper part of text

https://gerrit.wikimedia.org/r/886419

gerritbot added a project: Patch-For-Review.Feb 5 2023, 2:07 PM
gerritbot added a comment.Feb 5 2023, 2:10 PM

Change 886420 had a related patch set uploaded (by Cicalese; author: WgevaertWikiBase):

[mediawiki/extensions/DisplayTitle@REL1_39] Do not remove fragments if not proper part of text

https://gerrit.wikimedia.org/r/886420

gerritbot added a comment.Feb 5 2023, 2:12 PM

Change 886419 merged by jenkins-bot:

[mediawiki/extensions/DisplayTitle@REL1_38] Do not remove fragments if not proper part of text

https://gerrit.wikimedia.org/r/886419

gerritbot added a comment.Feb 5 2023, 2:15 PM

Change 886420 merged by jenkins-bot:

[mediawiki/extensions/DisplayTitle@REL1_39] Do not remove fragments if not proper part of text

https://gerrit.wikimedia.org/r/886420

Maintenance_bot removed a project: Patch-For-Review.Feb 5 2023, 2:30 PM
CCicalese_WMF mentioned this in rEDPTf5de9daf9db9: Do not remove fragments if not proper part of text.Feb 5 2023, 3:50 PM
CCicalese_WMF mentioned this in rEDPT14dfb9fe9922: Do not remove fragments if not proper part of text.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL