Page MenuHomePhabricator
Create Task
Maniphest T305645

Can't de-bold (or italic etc.) a table selection if one cell is empty
Closed, ResolvedPublic
Actions

Description

  1. Create a table with some content and an empty cell (e.g. https://en.wikipedia.beta.wmflabs.org/wiki/User:ESanders_(WMF)/table-bold?veaction=edit)
  2. Select across some content and the empty cell
  3. Press CTRL+B, observe all the content is bolded
  4. Press CTRL+B again, observe nothing happens

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (a0bf00838)mediawiki/extensions/VisualEditormaster+1 -1
Follow-up I26486e0e79: Fix when first range returns null annotation setVisualEditor/VisualEditormaster+21 -5
Update VE core submodule to master (0fde38782)mediawiki/extensions/VisualEditormaster+1 -1
getAnnotationsFromRange: Distinguish between "no annotations" and "no content"VisualEditor/VisualEditormaster+26 -4
Customize query in gerrit

Event Timeline

Esanders created this task.Apr 7 2022, 4:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 7 2022, 4:34 PM
• ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Apr 7 2022, 4:46 PM
gerritbot added a comment.Apr 7 2022, 4:52 PM

Change 778319 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] getAnnotationsFromRange: Distinguish between "no annotations" and "no content"

https://gerrit.wikimedia.org/r/778319

gerritbot added a project: Patch-For-Review.Apr 7 2022, 4:52 PM
gerritbot added a comment.Apr 7 2022, 11:08 PM

Change 778319 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] getAnnotationsFromRange: Distinguish between "no annotations" and "no content"

https://gerrit.wikimedia.org/r/778319

gerritbot added a comment.Apr 7 2022, 11:23 PM

Change 778365 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (0fde38782)

https://gerrit.wikimedia.org/r/778365

gerritbot added a comment.Apr 7 2022, 11:41 PM

Change 778365 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (0fde38782)

https://gerrit.wikimedia.org/r/778365

matmarex added a project: Editing-team (Kanban Board).Apr 7 2022, 11:51 PM
matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.
matmarex edited projects, added Editing QA; removed Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).Apr 8 2022, 12:00 AM
EAkinloose subscribed.EditedApr 11 2022, 3:40 AM

@Esanders , I think you should take a look at https://photos.app.goo.gl/oBzYyc768qzz69X17?
It is not consistent across the grid. It works in some rows and ignores others. I checked with columns seem to work fine.

Cc: @matmarex

EAkinloose moved this task from QA to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Apr 11 2022, 3:40 AM
EAkinloose added a subscriber: matmarex.
gerritbot added a comment.Apr 11 2022, 12:26 PM

Change 779021 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Follow-up I26486e0e79: Fix when first range returns null annotation set

https://gerrit.wikimedia.org/r/779021

gerritbot added a project: Patch-For-Review.Apr 11 2022, 12:26 PM
Esanders moved this task from Blocked / Needs More Work to Code Review on the Editing-team (Kanban Board) board.Apr 11 2022, 12:27 PM

Thanks @EAkinloose, good spot.

gerritbot added a comment.Apr 11 2022, 6:57 PM

Change 779021 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Follow-up I26486e0e79: Fix when first range returns null annotation set

https://gerrit.wikimedia.org/r/779021

gerritbot added a comment.Apr 11 2022, 7:22 PM

Change 779094 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a0bf00838)

https://gerrit.wikimedia.org/r/779094

gerritbot added a comment.Apr 11 2022, 7:38 PM

Change 779094 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a0bf00838)

https://gerrit.wikimedia.org/r/779094

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Apr 11 2022, 8:32 PM
matmarex removed a project: Patch-For-Review.
EAkinloose added a comment.Apr 12 2022, 12:12 AM

Works as expected across rows and columns. See https://photos.app.goo.gl/BrFMrGZnbQW8dx2u5.

EAkinloose edited projects, added Verified; removed Editing QA.Apr 12 2022, 12:12 AM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
• ppelberg closed this task as Resolved.Apr 22 2022, 11:52 PM
• ppelberg claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL