Echo has multiple namespaces
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Apr 8 2022, 12:12 AM

Description

	"AutoloadNamespaces": {
		"EchoOOUI\\": "includes/ooui/",
		"EchoPush\\": "includes/Push/",
		"EchoPush\\Api\\": "includes/api/Push/"
	},

As per https://www.mediawiki.org/wiki/Best_practices_for_extensions

SHOULD: Classes in MediaWiki\Extension\<ExtensionName> namespace. MediaWiki\<ExtensionName> is permissible if the extension name is a sufficiently unique word and not something generic (e.g. not a verb or noun).

I don't think Echo is necessarily something sufficiently unique... But having EchoOOUI and EchoPush doesn't seem right.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Move EchoPush\Api namespace to MediaWiki\Extension\Notifications\Push\Api	mediawiki/extensions/Echo	master	+7 -8
Move EchoOOUI namespace to MediaWiki\Extension\Notifications\OOUI	mediawiki/extensions/Echo	master	+5 -4
Move EchoPush namespace to MediaWiki\Extension\Notifications\Push	mediawiki/extensions/Echo	master	+38 -35

Customize query in gerrit

Related Objects

Mentioned Here: rEFLW25f2ee09ad35: Generate AbuseFilter variables for edits in recent_changes

Event Timeline

Reedy created this task.Apr 8 2022, 12:12 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 8 2022, 12:12 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 778368 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Echo@master] Move EchoOOUI namespace to MediaWiki\Extension\Notifications\Echo\OOUI

https://gerrit.wikimedia.org/r/778368

gerritbot added a project: Patch-For-Review.Apr 8 2022, 12:31 AM

Change 778369 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Echo@master] Move EchoPush namespace to MediaWiki\Extension\Notifications\Push

https://gerrit.wikimedia.org/r/778369

Change 778370 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Echo@master] Move EchoPush\Api namespace to MediaWiki\Extension\Notifications\Push\Api

https://gerrit.wikimedia.org/r/778370

• mewoph edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Apr 20 2022, 9:16 PM

• mewoph moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Nit: seems like a bad idea to have the extension name and the extension root namespace name be different.

In T305667#7875794, @Tgr wrote:

Nit: seems like a bad idea to have the extension name and the extension root namespace name be different.

+1 I'd prefer MediaWiki\Extension\Echo.

We're in a weird situation with Echo and Flow...

https://www.mediawiki.org/wiki/Notifications

Notifications (formerly known as Echo) is an...

vs https://www.mediawiki.org/wiki/Extension:Echo

The Echo extension provides an in-wiki notification system...

And we never seem to fully manage to rename anything.

Flow started using MediaWiki\Extension\StructuredDiscussions\ (rather than just Flow\) since rEFLW25f2ee09ad35: Generate AbuseFilter variables for edits in recent_changes.

I'm happy to update the patches to use MediaWiki\Extension\Echo. We should probably similarly "cleanup" Flow too though.

Oh yeah, that reminds me.. We can't use Echo.

12:50:10 Parse error: ./tests/phpunit/EchoHooksTest.php:3
12:50:10     1| <?php
12:50:10     2| 
12:50:10   > 3| use MediaWiki\Extension\Echo\Hooks as EchoHooks;
12:50:10     4| 
12:50:10     5| class EchoHooksTest extends MediaWikiIntegrationTestCase {
12:50:10 Unexpected 'Echo' (T_ECHO), expecting identifier (T_STRING) or '{' in ./tests/phpunit/EchoHooksTest.php on line 3
12:50:10 ------------------------------------------------------------
12:50:10 Parse error: ./includes/special/SpecialDisplayNotificationsConfiguration.php:3
12:50:10     1| <?php
12:50:10     2| 
12:50:10   > 3| use MediaWiki\Extension\Echo\Hooks as EchoHooks;
12:50:10     4| use MediaWiki\User\UserOptionsManager;
12:50:10     5| 
12:50:10 Unexpected 'Echo' (T_ECHO), expecting identifier (T_STRING) or '{' in ./includes/special/SpecialDisplayNotificationsConfiguration.php on line 3

IIRC, this isn't an issue when we bump to PHP 8.0 or so.

Change 778368 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Move EchoOOUI namespace to MediaWiki\Extension\Notifications\OOUI

https://gerrit.wikimedia.org/r/778368

Change 778369 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Move EchoPush namespace to MediaWiki\Extension\Notifications\Push

https://gerrit.wikimedia.org/r/778369

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.9; 2022-04-25).Apr 25 2022, 3:00 PM

Change 778370 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Move EchoPush\Api namespace to MediaWiki\Extension\Notifications\Push\Api

https://gerrit.wikimedia.org/r/778370

Maintenance_bot removed a project: Patch-For-Review.Apr 25 2022, 11:30 PM