Page MenuHomePhabricator

Call to a member function getText() on null with EditNotify
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Adding large amounts of text or removing a large amount of text from a page

What happens?:

Call to a member function getText() on null
from /srv/mediawiki/w/extensions/EditNotify/includes/EditNotifyHooks.php(306)
#0 /srv/mediawiki/w/includes/HookContainer/HookContainer.php(338): EditNotifyHooks::onPageContentSave(WikiPage, User, WikitextContent, CommentStoreComment, integer, NULL, NULL, integer, Status)
#1 /srv/mediawiki/w/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#2 /srv/mediawiki/w/includes/HookContainer/HookRunner.php(2714): MediaWiki\HookContainer\HookContainer->run(string, array)
#3 /srv/mediawiki/w/includes/Storage/PageUpdater.php(807): MediaWiki\HookContainer\HookRunner->onPageContentSave(WikiPage, User, WikitextContent, CommentStoreComment, integer, NULL, NULL, integer, Status)
#4 /srv/mediawiki/w/includes/page/WikiPage.php(1994): MediaWiki\Storage\PageUpdater->saveRevision(CommentStoreComment, integer)
#5 /srv/mediawiki/w/includes/EditPage.php(2351): WikiPage->doUserEditContent(WikitextContent, User, CommentStoreComment, integer, boolean, array, integer)
#6 /srv/mediawiki/w/includes/EditPage.php(1687): EditPage->internalAttemptSave(array, boolean)
#7 /srv/mediawiki/w/includes/EditPage.php(665): EditPage->attemptSave(array)
#8 /srv/mediawiki/w/includes/actions/EditAction.php(71): EditPage->edit()
#9 /srv/mediawiki/w/includes/actions/SubmitAction.php(38): EditAction->show()
#10 /srv/mediawiki/w/includes/MediaWiki.php(543): SubmitAction->show()
#11 /srv/mediawiki/w/includes/MediaWiki.php(320): MediaWiki->performAction(Article, Title)
#12 /srv/mediawiki/w/includes/MediaWiki.php(930): MediaWiki->performRequest()
#13 /srv/mediawiki/w/includes/MediaWiki.php(564): MediaWiki->main()
#14 /srv/mediawiki/w/index.php(53): MediaWiki->run()
#15 /srv/mediawiki/w/index.php(46): wfIndexMain()
#16 {main}

What should have happened instead?:
Editing pages should be working normally

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

MediaWiki 1.37.2 (8c55172)
PHP 7.4.28 (fpm-fcgi)
MariaDB 10.5.15-MariaDB-1:10.5.15+maria~bullseye-log

Downstream: https://phabricator.miraheze.org/T8996

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 874885 had a related patch set uploaded (by Yaron Koren; author: Yaron Koren):

[mediawiki/extensions/EditNotify@master] Fix for handling pages with unstored template links

https://gerrit.wikimedia.org/r/874885

Change 874885 merged by jenkins-bot:

[mediawiki/extensions/EditNotify@master] Fix for handling pages with unstored template links

https://gerrit.wikimedia.org/r/874885

Yaron_Koren claimed this task.
Yaron_Koren subscribed.

I'm not sure, but I believe this is fixed now.