Page MenuHomePhabricator
Create Task
Maniphest T305761

Broken "review/manage" link in List OAuth applications
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:

"No such special page
You have requested an invalid special page."

What should have happened instead?:

Be able to manage the App permissions

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
Chrome: Versão 99.0.4844.84 (Compilação oficial) (64 bits)

image.png (268×437 px, 12 KB)
image.png (321×651 px, 23 KB)

Details

SubjectRepoBranchLines +/-
OAuthListConsumers: Only show manage link if user has the rightmediawiki/extensions/OAuthREL1_36+1 -1
OAuthListConsumers: Only show manage link if user has the rightmediawiki/extensions/OAuthREL1_37+1 -1
OAuthListConsumers: Only show manage link if user has the rightmediawiki/extensions/OAuthREL1_38+1 -1
OAuthListConsumers: Only show manage link if user has the rightmediawiki/extensions/OAuthmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Darwinius created this task.Apr 8 2022, 10:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 8 2022, 10:54 PM
Darwinius added a project: MediaWiki-extensions-OAuth.Apr 8 2022, 10:55 PM
Reedy subscribed.Apr 8 2022, 11:02 PM

I think this is a regression from rEOAU08f09ec725ae: OAuth: Replace User::isAllowed calls with PermissionManager..

gerritbot added a comment.Apr 8 2022, 11:02 PM

Change 778600 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OAuth@master] Only show manage link if user has the right

https://gerrit.wikimedia.org/r/778600

gerritbot added a project: Patch-For-Review.Apr 8 2022, 11:02 PM
Reedy added projects: MW-1.36-release, MW-1.37-release, MW-1.38-release.Apr 8 2022, 11:03 PM
Reedy triaged this task as Low priority.Apr 8 2022, 11:08 PM
Reedy added a project: Regression.
gerritbot added a comment.Apr 9 2022, 11:34 AM

Change 778244 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OAuth@REL1_38] OAuthListConsumers: Only show manage link if user has the right

https://gerrit.wikimedia.org/r/778244

gerritbot added a comment.Apr 9 2022, 11:34 AM

Change 778245 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OAuth@REL1_37] OAuthListConsumers: Only show manage link if user has the right

https://gerrit.wikimedia.org/r/778245

gerritbot added a comment.Apr 9 2022, 11:34 AM

Change 778626 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OAuth@REL1_36] OAuthListConsumers: Only show manage link if user has the right

https://gerrit.wikimedia.org/r/778626

gerritbot added a comment.Apr 9 2022, 11:38 AM

Change 778600 merged by jenkins-bot:

[mediawiki/extensions/OAuth@master] OAuthListConsumers: Only show manage link if user has the right

https://gerrit.wikimedia.org/r/778600

gerritbot added a comment.Apr 9 2022, 11:41 AM

Change 778244 merged by jenkins-bot:

[mediawiki/extensions/OAuth@REL1_38] OAuthListConsumers: Only show manage link if user has the right

https://gerrit.wikimedia.org/r/778244

gerritbot added a comment.Apr 9 2022, 11:45 AM

Change 778245 merged by jenkins-bot:

[mediawiki/extensions/OAuth@REL1_37] OAuthListConsumers: Only show manage link if user has the right

https://gerrit.wikimedia.org/r/778245

gerritbot added a comment.Apr 9 2022, 11:45 AM

Change 778626 merged by jenkins-bot:

[mediawiki/extensions/OAuth@REL1_36] OAuthListConsumers: Only show manage link if user has the right

https://gerrit.wikimedia.org/r/778626

Reedy closed this task as Resolved.Apr 9 2022, 11:55 AM
Reedy claimed this task.
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).Apr 9 2022, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 9 2022, 12:30 PM
Darwinius added a comment.EditedApr 9 2022, 7:45 PM

@Reedy This task was closed as resolved, but the error is still there...

Reedy added a comment.Apr 9 2022, 8:34 PM

Yes. That’s standard practice. The code has been fixed, it will be deployed in the next train. Which will fix it

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL