Page MenuHomePhabricator

BundleSizeTest for a skin tests the default skin
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce:

  • Install MinervaNeue skin which defines its BundleSizeTest.php and bundlesize.config.json
  • Install a larger skin than Minerva and set it to the default skin.
  • Run PHPUnit.

What happens?:

BundleSizeTest.php tests with MediaWikiServices::getInstance()->getMainConfig()->get( 'DefaultSkin' ) skin,
so if the default skin is larger then the target of the test, there is failures: (full log)

1) MediaWiki\Skins\MinervaNeue\Tests\Structure\BundleSizeTest::testBundleSize
skins.minerva.mainMenu.icons is less than 409.6
Failed asserting that 410 is less than 409.60000000000002.

/workspace/src/tests/phpunit/structure/BundleSizeTest.php:59
/workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:467

What should have happened instead?:

There should be no failure.

Software version:

MediaWiki: 1.39 a01dbf1e075f10594729b4ffe927293915344cd6
MinervaNeue: 916e8bc9c1b47eb09f8d032dd5a2e18e3b0ddec2

Event Timeline

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript
Lens0021 renamed this task from Setting SkinOOUIThemes increases the bundlesize of other skin's OOUIIconPackModule to BundleSizeTest for a skin tests the default skin.Apr 9 2022, 11:58 AM
Lens0021 removed a project: OOUI.
Lens0021 updated the task description. (Show Details)

Change 778611 had a related patch set uploaded (by Lens0021; author: Lens0021):

[mediawiki/core@master] BundleSizeTest: Give a setting skin name chance to subclasses

https://gerrit.wikimedia.org/r/778611

Change 778613 had a related patch set uploaded (by Lens0021; author: Lens0021):

[mediawiki/skins/MinervaNeue@master] BundleSizeTest: Extend ::getSkinName()

https://gerrit.wikimedia.org/r/778613

Change 778611 merged by jenkins-bot:

[mediawiki/core@master] phpunit: Support setting skin context in BundleSizeTest subclasses

https://gerrit.wikimedia.org/r/778611

Change 778613 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] phpunit: Implement the new BundleSizeTest::getSkinName()

https://gerrit.wikimedia.org/r/778613

Change 789166 had a related patch set uploaded (by Lens0021; author: Lens0021):

[mediawiki/skins/MinervaNeue@REL1_38] phpunit: Implement the new BundleSizeTest::getSkinName()

https://gerrit.wikimedia.org/r/789166

Change 789167 had a related patch set uploaded (by Lens0021; author: Lens0021):

[mediawiki/core@REL1_38] phpunit: Support setting skin context in BundleSizeTest subclasses

https://gerrit.wikimedia.org/r/789167

Change 789167 merged by jenkins-bot:

[mediawiki/core@REL1_38] phpunit: Support setting skin context in BundleSizeTest subclasses

https://gerrit.wikimedia.org/r/789167

Change 789166 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@REL1_38] phpunit: Implement the new BundleSizeTest::getSkinName()

https://gerrit.wikimedia.org/r/789166