Page MenuHomePhabricator

Use MainConfigNames constants instead of string literals
Closed, ResolvedPublic

Description

We currently use string literals for identifying configuration options. This precludes automatic validation. We apparently want to switch to the MainConfigNames constants instead. This will involve lots of manually-reviewed search and replace.

Event Timeline

Change 778671 had a related patch set uploaded (by Simetrical; author: Simetrical):

[mediawiki/core@master] Use MainConfigNames instead of string literals

https://gerrit.wikimedia.org/r/778671

Change 778671 merged by jenkins-bot:

[mediawiki/core@master] Use MainConfigNames instead of string literals

https://gerrit.wikimedia.org/r/778671

Change 785913 had a related patch set uploaded (by Simetrical; author: Simetrical):

[mediawiki/core@master] Use MainConfigNames instead of string literals, #3

https://gerrit.wikimedia.org/r/785913

Change 785913 merged by jenkins-bot:

[mediawiki/core@master] Use MainConfigNames instead of string literals, #3

https://gerrit.wikimedia.org/r/785913

Change 786345 had a related patch set uploaded (by Simetrical; author: Simetrical):

[mediawiki/core@master] Use MainConfigNames instead of string literals, #4

https://gerrit.wikimedia.org/r/786345

Change 786345 merged by jenkins-bot:

[mediawiki/core@master] Use MainConfigNames instead of string literals, #4

https://gerrit.wikimedia.org/r/786345

I think this is done in core, at least for now. I'm sure more instances will crop up for a while to come, so it probably deserves checking again sometime in the future.