Page MenuHomePhabricator

Remove deprecations of Http class in extensions
Open, Needs TriagePublic

Description

Follow up to T214390: Refactor the Http class to not use global state

Per CS (https://codesearch.wmcloud.org/search/?q=Http%3A%3A&i=nope&files=&excludeFiles=&repos=), we've got some WMF deployed extensions before this class goes away

  • extensions / LocalisationUpdate
  • extensions / CodeReview
  • extensions / Collection
  • extensions / DonationInterface
  • extensions / Elastica
  • extensions / ExtensionDistributor -- 785813 (example)
  • extensions / FileImporter -- 785816 (example)
  • extensions / Math
  • extensions / PageImages
  • extensions / PageViewInfo
  • extensions / SecurePoll
  • extensions / TorBlock
  • extensions / Translate
  • extensions / UploadWizard
  • extensions / WikimediaMaintenance

Event Timeline

Change 778681 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/RSS@master] Replace Http::isValidURI with MWHttpRequest::isValidURI

https://gerrit.wikimedia.org/r/778681

Change 778993 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] Replace Http::userAgent() with HttpRequestFactory

https://gerrit.wikimedia.org/r/778993

Change 778681 merged by jenkins-bot:

[mediawiki/extensions/RSS@master] Replace Http::isValidURI with MWHttpRequest::isValidURI

https://gerrit.wikimedia.org/r/778681

Change 778993 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Replace Http::userAgent() with HttpRequestFactory

https://gerrit.wikimedia.org/r/778993

Per CS (https://codesearch.wmcloud.org/search/?q=Http%3A%3A&i=nope&files=&excludeFiles=&repos=), we've got some WMF deployed extensions before this class goes away

  • extensions / LocalisationUpdate
  • extensions / CodeReview
  • extensions / Collection
  • extensions / DonationInterface
  • extensions / Elastica
  • extensions / ExtensionDistributor
  • extensions / FileImporter
  • extensions / Math
  • extensions / PageImages
  • extensions / PageViewInfo
  • extensions / SecurePoll
  • extensions / TorBlock
  • extensions / Translate
  • extensions / UploadWizard
  • extensions / WikimediaMaintenance

Change 785813 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/ExtensionDistributor@master] Providers: Use HttpRequestFactory service instead of `Http::class`

https://gerrit.wikimedia.org/r/785813

Change 785816 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/FileImporter@master] Services: Update documentation to reference the new service

https://gerrit.wikimedia.org/r/785816

Change 785816 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Services: Update documentation to reference the new service

https://gerrit.wikimedia.org/r/785816

Change 785813 merged by jenkins-bot:

[mediawiki/extensions/ExtensionDistributor@master] Providers: Use HttpRequestFactory service instead of `Http::class`

https://gerrit.wikimedia.org/r/785813