Page MenuHomePhabricator

Rename "suspend"/"resume" commands
Closed, ResolvedPublic

Description

To me "suspend" and "resume" are a bit long winded. I would like to use "stop" and "start" instead (or perhaps as well as via an alias).

It would also be useful to have a "restart" command. https://phabricator.wikimedia.org/T305943

Related Objects

Event Timeline

There was some thinking on the topic of names while this was still mediawiki-docker-dev
https://github.com/addshore/mediawiki-docker-dev/issues/80
(issue archived so I'll quote the content here...

@Krinkle

Currently, the names for the subset of scripts that change the existence or state of the environment, are:

  • mdd up
  • mdd down
  • mdd stop
  • mdd start

And soon:

Proposal:

  • mdd install
  • mdd create
  • mdd destroy
  • mdd suspend
  • mdd resume

@kostajh

I have inadvertently destroyed my database with “down” before; “destroy” and “suspend” would be more clear IMO.

@Addshore

Sounds like a great naming change.

I guess the only sensible thing to do would be to have aliases?
But I wonder if the defaults should then also switch to stop, start, restart etc.?


It would also be useful to have a "restart" command.

Can you write this as a separate ticket please?

I guess the only sensible thing to do would be to have aliases?

Yeah, alias seem like a good idea =)

But I wonder if the defaults should then also switch to stop, start, restart etc.?

I think that "start" and "stop" is clearer than "resume" and "suspend". The containers are stopped not paused. I don't think using "stop" would add any confusion/ambiguity with any other commands (e.g. "destroy"). It would also look more natural along side a "restart" command (if that is implemented) as opposed to "resume"/"suspend"/"restart".

Ollie.Shotton_WMDE renamed this task from Improve suspend/resume commands to Rename "suspend"/"resume" commands.Apr 13 2022, 10:25 AM
Addshore moved this task from Backlog to In Progress on the mwcli board.