Page MenuHomePhabricator
Create Task
Maniphest T305824

Provide a meaningful Retry-After value
Closed, ResolvedPublic
Actions

Description

Right now text has hardcoded Retry-After: 1 for every 429 request.

Requestctl could provide a more accurate value iff threshold_duration is provided

Details

SubjectRepoBranchLines +/-
varnish: set retry-after based on throttle duration in requestctloperations/puppetproduction+15 -2
requestctl: add retry-after request header when applicableoperations/software/conftoolmaster+11 -8
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
Restricted Task
 OpenNoneT305580 requestctl v1 improvements
 ResolvedJoeT305824 Provide a meaningful Retry-After value

Event Timeline

Vgutierrez created this task.Apr 11 2022, 10:09 AM
Vgutierrez triaged this task as Medium priority.Apr 21 2022, 9:34 AM
Vgutierrez added a comment.May 11 2022, 10:51 AM

The data could be passed via an HTTP header on the req object on cluster_fe_ratelimit and picked up on wikimedia-frontend vcl_synth to set the response header. Considering that the request won't leave varnish it doesn't look like an awful solution to pass the data from request to response context.

gerritbot added a comment.May 11 2022, 11:23 AM

Change 791006 had a related patch set uploaded (by Giuseppe Lavagetto; author: Giuseppe Lavagetto):

[operations/software/conftool@master] requestctl: add retry-after request header when applicable

https://gerrit.wikimedia.org/r/791006

gerritbot added a project: Patch-For-Review.May 11 2022, 11:23 AM
Joe moved this task from Backlog to in progress on the conftool board.May 11 2022, 2:56 PM
Joe claimed this task.May 11 2022, 4:09 PM
gerritbot added a comment.May 12 2022, 1:16 PM

Change 791006 merged by jenkins-bot:

[operations/software/conftool@master] requestctl: add retry-after request header when applicable

https://gerrit.wikimedia.org/r/791006

gerritbot added a comment.May 12 2022, 1:26 PM

Change 791373 had a related patch set uploaded (by Giuseppe Lavagetto; author: Giuseppe Lavagetto):

[operations/puppet@production] varnish: set retry-after based on throttle duration in requestctl

https://gerrit.wikimedia.org/r/791373

Joe mentioned this in rOSCT3854c4847cdd: requestctl: add retry-after request header when applicable.May 12 2022, 1:43 PM
Stashbot mentioned this in T305607: Support NOT in the dsl grammar.May 13 2022, 3:57 PM
Stashbot mentioned this in T305638: requestctl should have a "find actions using pattern foo" feature.
Stashbot mentioned this in T308100: Invalid confctl selector should either error out or select nothing.
Stashbot mentioned this in T305582: Annotate X-Analytics header with any matching actions.
Stashbot mentioned this in T307905: Add validate function to conftool reqconfig extension.

Mentioned in SAL (#wikimedia-operations) [2022-05-13T15:57:06Z] <_joe_> uploading conftool 2.2.0 to buster, bullseye T305824 T305582 T305607 T305638 T307905 T308100

Joe closed this task as Resolved.May 17 2022, 6:25 AM
gerritbot added a comment.May 18 2022, 2:26 PM

Change 791373 merged by Giuseppe Lavagetto:

[operations/puppet@production] varnish: set retry-after based on throttle duration in requestctl

https://gerrit.wikimedia.org/r/791373

Maintenance_bot removed a project: Patch-For-Review.May 18 2022, 2:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL