Maniphest T305833

Double quote ETag in Wikibase REST API respones
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	WMDE-leszek
	Apr 11 2022, 11:05 AM

Tags

Referenced Files

None

Subscribers

Ollie.Shotton_WMDE

Description

Per RFC 7232, ETag value in HTTP headers should be a quoted string: https://httpwg.org/specs/rfc7232.html#header.etag

Current response of the Wikibase REST API uses the revision ID in a non-quoted form, see

HTTP/1.1 200 OK
Date: Mon, 11 Apr 2022 09:26:28 GMT
Content-Type: application/json
...
Last-Modified: Mon, 21 Mar 2022 11:38:20 GMT
ETag: 10
...

whereas it should be

...
ETag: "10"
...

Details

	Subject	Repo	Branch	Lines +/-
	REST: Ensure ETag header is quoted	mediawiki/extensions/Wikibase	master	+22 -14

Customize query in gerrit

Event Timeline

WMDE-leszek created this task.Apr 11 2022, 11:05 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 11 2022, 11:05 AM

Ollie.Shotton_WMDE subscribed.Apr 11 2022, 12:02 PM

Change 779061 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Ensure ETag header is quoted

https://gerrit.wikimedia.org/r/779061

gerritbot added a project: Patch-For-Review.Apr 11 2022, 3:32 PM

WMDE-leszek moved this task from Backlog to Next on the Wikibase Product Platform (v1) board.Apr 11 2022, 7:43 PM

Jakob_WMDE claimed this task.Apr 12 2022, 12:47 PM

Jakob_WMDE removed Jakob_WMDE as the assignee of this task.

Jakob_WMDE moved this task from Next to Sprint 3 on the Wikibase Product Platform (v1) board.

Jakob_WMDE edited projects, added Wikibase Product Platform (v1) (Sprint 3); removed Wikibase Product Platform (v1).

Jakob_WMDE moved this task from To Do to Peer Review on the Wikibase Product Platform (v1) (Sprint 3) board.

Jakob_WMDE subscribed.

Change 779061 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Ensure ETag header is quoted

https://gerrit.wikimedia.org/r/779061

Maintenance_bot removed a project: Patch-For-Review.Apr 12 2022, 2:29 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.8; 2022-04-18).Apr 12 2022, 3:00 PM

Ollie.Shotton_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 3) board.Apr 12 2022, 3:01 PM

WMDE-leszek closed this task as Resolved.Apr 19 2022, 9:07 PM

WMDE-leszek claimed this task.