| Jdlrobson | |
| Apr 12 2022, 9:40 PM |
| F35060190: Screen Recording 2022-04-20 at 8.02.59 AM.mov.gif | |
| Apr 20 2022, 3:23 PM |
Expected: sidebar is still hidden
Actual: sidebar is open
SkinVector::isSidebarVisible alway seems to return false.
I believe we (I) broke the registration of the preference in onGetPreferences in I7454d8f1cfdef81e7f3df476d8ce86736b46fff2
Probably worth adding a UI regression test for this.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Restore persistent sidebar | mediawiki/skins/Vector | master | +20 -0 |
Estimated as a medium. Not sure if a visual regression test is worth it at this point given this would require setting up a test with interactions. While doable, I'd prefer to keep the tests cheap with no interactions right now until we better understand whether this kind of bug is better suited for a unit test, end-to-end, or visual regression test.
Change 781048 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/Vector@master] Restore persistent sidebar
Change 781048 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Restore persistent sidebar
@ovasileva in the screengrab below when I close the sidebar (the second half of the video) and do a hard reload, it comes back open. I cannot recreate this consistently. I was able to see it more often when I throttled the connection.
@ovasileva in the screengrab below when I close the sidebar (the second half of the video) and do a hard reload, it comes back open. I cannot recreate this consistently. I was able to see it more often when I throttled the connection.
I think that if it's only while throttling the connection, it should be okay. @Jdlrobson - any thoughts on this one/what is causing it?
@Edtadros - discussed this and this behavior is expected when conneciton is throttled. Resolving this one.