Page MenuHomePhabricator

Canonicalization Inappropriately Replaces List Element with Z40
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • take this ZObject:
{
  "Z1K1": {
    "Z1K1": "Z9",
    "Z9K1": "Z22"
  },
  "Z22K1": {
    "Z1K1": {
      "Z1K1": "Z9",
      "Z9K1": "Z8"
    },
    "Z8K1": {
      "Z1K1": {
        "Z1K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z7"
        },
        "Z7K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z881"
        },
        "Z881K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z17"
        }
      },
      "K1": {
        "Z1K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z17"
        },
        "Z17K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z40"
        },
        "Z17K2": {
          "Z1K1": "Z6",
          "Z6K1": "Z31002K1"
        },
        "Z17K3": {
          "Z1K1": {
            "Z1K1": "Z9",
            "Z9K1": "Z12"
          },
          "Z12K1": {
            "Z1K1": {
              "Z1K1": {
                "Z1K1": "Z9",
                "Z9K1": "Z7"
              },
              "Z7K1": {
                "Z1K1": "Z9",
                "Z9K1": "Z881"
              },
              "Z881K1": {
                "Z1K1": "Z9",
                "Z9K1": "Z1"
              }
            }
          }
        }
      },
      "K2": {
        "Z1K1": {
          "Z1K1": {
            "Z1K1": "Z9",
            "Z9K1": "Z7"
          },
          "Z7K1": {
            "Z1K1": "Z9",
            "Z9K1": "Z881"
          },
          "Z881K1": {
            "Z1K1": "Z9",
            "Z9K1": "Z17"
          }
        }
      }
    },
    "Z8K2": {
      "Z1K1": "Z9",
      "Z9K1": "Z40"
    },
    "Z8K3": {
      "Z1K1": {
        "Z1K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z7"
        },
        "Z7K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z881"
        },
        "Z881K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z1"
        }
      }
    },
    "Z8K4": {
      "Z1K1": {
        "Z1K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z7"
        },
        "Z7K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z881"
        },
        "Z881K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z14"
        }
      },
      "K1": {
        "Z1K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z14"
        },
        "Z14K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z31002"
        },
        "Z14K2": {
          "Z1K1": {
            "Z1K1": "Z9",
            "Z9K1": "Z7"
          },
          "Z7K1": {
            "Z1K1": "Z9",
            "Z9K1": "Z10007"
          },
          "K1": {
            "Z1K1": {
              "Z1K1": "Z9",
              "Z9K1": "Z40"
            },
            "Z40K1": {
              "Z1K1": "Z9",
              "Z9K1": "Z41"
            }
          },
          "K2": {
            "Z1K1": {
              "Z1K1": "Z9",
              "Z9K1": "Z18"
            },
            "Z18K1": {
              "Z1K1": "Z6",
              "Z6K1": "Z31002K1"
            }
          }
        }
      },
      "K2": {
        "Z1K1": {
          "Z1K1": {
            "Z1K1": "Z9",
            "Z9K1": "Z7"
          },
          "Z7K1": {
            "Z1K1": "Z9",
            "Z9K1": "Z881"
          },
          "Z881K1": {
            "Z1K1": "Z9",
            "Z9K1": "Z14"
          }
        }
      }
    },
    "Z8K5": {
      "Z1K1": "Z9",
      "Z9K1": "Z31002"
    }
  },
  "Z22K2": {
    "Z1K1": "Z9",
    "Z9K1": "Z23"
  }
}
  • canonicalize it
  • notice that the very important Z14 is replaced by a Z40

What happens?:

What should have happened instead?:

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Event Timeline

Change 779908 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-schemata@master] Fix bug where canonicalization converts an innocent function call into a list(Boolean).

https://gerrit.wikimedia.org/r/779908

Change 779908 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Fix bug where canonicalization converts an innocent function call into a list(Boolean).

https://gerrit.wikimedia.org/r/779908

Change 780894 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (fd55995)

https://gerrit.wikimedia.org/r/780894

Change 780894 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (fd55995)

https://gerrit.wikimedia.org/r/780894

Change 785854 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (49ff68e)

https://gerrit.wikimedia.org/r/785854

Change 785856 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (49ff68e)

https://gerrit.wikimedia.org/r/785856

Change 785854 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (49ff68e)

https://gerrit.wikimedia.org/r/785854

Change 785856 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (49ff68e)

https://gerrit.wikimedia.org/r/785856