Canonicalization Inappropriately Replaces List Element with Z40
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	cmassaro
	Apr 12 2022, 10:13 PM

Description

List of steps to reproduce (step by step, including full links if applicable):

take this ZObject:

{
  "Z1K1": {
    "Z1K1": "Z9",
    "Z9K1": "Z22"
  },
  "Z22K1": {
    "Z1K1": {
      "Z1K1": "Z9",
      "Z9K1": "Z8"
    },
    "Z8K1": {
      "Z1K1": {
        "Z1K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z7"
        },
        "Z7K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z881"
        },
        "Z881K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z17"
        }
      },
      "K1": {
        "Z1K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z17"
        },
        "Z17K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z40"
        },
        "Z17K2": {
          "Z1K1": "Z6",
          "Z6K1": "Z31002K1"
        },
        "Z17K3": {
          "Z1K1": {
            "Z1K1": "Z9",
            "Z9K1": "Z12"
          },
          "Z12K1": {
            "Z1K1": {
              "Z1K1": {
                "Z1K1": "Z9",
                "Z9K1": "Z7"
              },
              "Z7K1": {
                "Z1K1": "Z9",
                "Z9K1": "Z881"
              },
              "Z881K1": {
                "Z1K1": "Z9",
                "Z9K1": "Z1"
              }
            }
          }
        }
      },
      "K2": {
        "Z1K1": {
          "Z1K1": {
            "Z1K1": "Z9",
            "Z9K1": "Z7"
          },
          "Z7K1": {
            "Z1K1": "Z9",
            "Z9K1": "Z881"
          },
          "Z881K1": {
            "Z1K1": "Z9",
            "Z9K1": "Z17"
          }
        }
      }
    },
    "Z8K2": {
      "Z1K1": "Z9",
      "Z9K1": "Z40"
    },
    "Z8K3": {
      "Z1K1": {
        "Z1K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z7"
        },
        "Z7K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z881"
        },
        "Z881K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z1"
        }
      }
    },
    "Z8K4": {
      "Z1K1": {
        "Z1K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z7"
        },
        "Z7K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z881"
        },
        "Z881K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z14"
        }
      },
      "K1": {
        "Z1K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z14"
        },
        "Z14K1": {
          "Z1K1": "Z9",
          "Z9K1": "Z31002"
        },
        "Z14K2": {
          "Z1K1": {
            "Z1K1": "Z9",
            "Z9K1": "Z7"
          },
          "Z7K1": {
            "Z1K1": "Z9",
            "Z9K1": "Z10007"
          },
          "K1": {
            "Z1K1": {
              "Z1K1": "Z9",
              "Z9K1": "Z40"
            },
            "Z40K1": {
              "Z1K1": "Z9",
              "Z9K1": "Z41"
            }
          },
          "K2": {
            "Z1K1": {
              "Z1K1": "Z9",
              "Z9K1": "Z18"
            },
            "Z18K1": {
              "Z1K1": "Z6",
              "Z6K1": "Z31002K1"
            }
          }
        }
      },
      "K2": {
        "Z1K1": {
          "Z1K1": {
            "Z1K1": "Z9",
            "Z9K1": "Z7"
          },
          "Z7K1": {
            "Z1K1": "Z9",
            "Z9K1": "Z881"
          },
          "Z881K1": {
            "Z1K1": "Z9",
            "Z9K1": "Z14"
          }
        }
      }
    },
    "Z8K5": {
      "Z1K1": "Z9",
      "Z9K1": "Z31002"
    }
  },
  "Z22K2": {
    "Z1K1": "Z9",
    "Z9K1": "Z23"
  }
}

canonicalize it
notice that the very important Z14 is replaced by a Z40

What happens?:

What should have happened instead?:

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Update function-schemata sub-module to HEAD (49ff68e)	mediawiki/extensions/WikiLambda	master	+1 -1
Update function-schemata sub-module to HEAD (49ff68e)	mediawiki/services/function-evaluator	master	+1 -1
Update function-schemata sub-module to HEAD (fd55995)	mediawiki/services/function-orchestrator	master	+11 -3
Fix bug where canonicalization converts an innocent function call into a list(Boolean).	mediawiki/services/function-schemata	master	+25 -4

Customize query in gerrit

Related Objects

Mentioned In: rMSFE9b1424da84fc: Update function-schemata sub-module to HEAD (49ff68e)
rMSFO8a4a1bc9bcff: Update function-schemata sub-module to HEAD (fd55995)
T303471: Allow for Boolean Curry to work by supporting closures
rMSFSfd559951d3a9: Fix bug where canonicalization converts an innocent function call into a list…

Event Timeline

cmassaro created this task.Apr 12 2022, 10:13 PM

Change 779908 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-schemata@master] Fix bug where canonicalization converts an innocent function call into a list(Boolean).

https://gerrit.wikimedia.org/r/779908

gerritbot added a project: Patch-For-Review.Apr 13 2022, 7:33 PM

Change 779908 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Fix bug where canonicalization converts an innocent function call into a list(Boolean).

https://gerrit.wikimedia.org/r/779908

cmassaro mentioned this in rMSFSfd559951d3a9: Fix bug where canonicalization converts an innocent function call into a list….Apr 13 2022, 8:51 PM

Jdforrester-WMF mentioned this in T303471: Allow for Boolean Curry to work by supporting closures.Apr 13 2022, 9:20 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 13 2022, 9:30 PM

Change 780894 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (fd55995)

https://gerrit.wikimedia.org/r/780894

gerritbot added a project: Patch-For-Review.Apr 14 2022, 4:35 PM

Change 780894 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (fd55995)

https://gerrit.wikimedia.org/r/780894

Jdforrester-WMF mentioned this in rMSFO8a4a1bc9bcff: Update function-schemata sub-module to HEAD (fd55995).Apr 14 2022, 4:51 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 14 2022, 5:30 PM

cmassaro added a project: function-schemata.Apr 15 2022, 10:13 PM

cmassaro claimed this task.Apr 18 2022, 3:01 PM

Jdforrester-WMF closed this task as Resolved.Apr 19 2022, 4:19 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.

Change 785854 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (49ff68e)

https://gerrit.wikimedia.org/r/785854

gerritbot added a project: Patch-For-Review.Apr 25 2022, 2:00 PM

Change 785856 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (49ff68e)

https://gerrit.wikimedia.org/r/785856

Change 785854 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (49ff68e)

https://gerrit.wikimedia.org/r/785854

Jdforrester-WMF mentioned this in rMSFE9b1424da84fc: Update function-schemata sub-module to HEAD (49ff68e).May 2 2022, 4:54 PM

Change 785856 merged by jenkins-bot: