Placeholder is on wrong side when using different interface direction to content
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Apr 13 2022, 3:23 PM

Description

Visit https://meta.wikimedia.org/wiki/Talk:Wikimedia_Foundation_Community_Affairs_Committee?uselang=ar
Observe that the reply tool interface is RTL, but the reply tool input box is supposed to be LTR, however the placeholder is right-aligned as if the input box is RTL:

placehoder	text

Expected:
The placeholder is always left-aligned like the content on an LTR wiki, regardless of interface language.

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (038522816)	mediawiki/extensions/VisualEditor	master	+1 -1
	Set dir/lang props on placeholder element	VisualEditor/VisualEditor	master	+5 -0

Customize query in gerrit

Related Objects

Mentioned In: T306137: Reply tool interface looks messed up when replying to a bullet list while using different interface direction to content

Event Timeline

Esanders created this task.Apr 13 2022, 3:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2022, 3:23 PM

Change 779893 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Set dir/lang props on placeholder element

https://gerrit.wikimedia.org/r/779893

gerritbot added a project: Patch-For-Review.Apr 13 2022, 3:24 PM

Esanders moved this task from To Triage to Triaged on the VisualEditor board.Apr 13 2022, 3:27 PM

matmarex renamed this task from Placeholder is on wrong size when using different interface direction to content to Placeholder is on wrong side when using different interface direction to content.Apr 13 2022, 9:39 PM

matmarex mentioned this in T306137: Reply tool interface looks messed up when replying to a bullet list while using different interface direction to content.

matmarex added a project: Editing-team (Kanban Board).

Change 779893 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Set dir/lang props on placeholder element

https://gerrit.wikimedia.org/r/779893

ppelberg subscribed.Apr 13 2022, 9:51 PM

Change 779957 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (038522816)

https://gerrit.wikimedia.org/r/779957

Change 779957 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (038522816)

https://gerrit.wikimedia.org/r/779957

Maintenance_bot removed a project: Patch-For-Review.Apr 13 2022, 10:30 PM

matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.Apr 13 2022, 10:32 PM

matmarex added a project: Editing QA.

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.8; 2022-04-18).Apr 13 2022, 11:00 PM

Testing with https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Main_Page?uselang=ar, it works as expected:

placeholder:

Screenshot 2022-04-19 at 11.57.31.png (898×2 px, 168 KB)

text:

Screenshot 2022-04-19 at 12.02.02.png (872×1 px, 160 KB)

Further observations to confirm the above:

Testing on https://ar.wikipedia.beta.wmflabs.org/wiki/%D9%86%D9%82%D8%A7%D8%B4_%D8%A7%D9%84%D9%85%D8%B3%D8%AA%D8%AE%D8%AF%D9%85:TestEsther

placeholder:

Screenshot 2022-04-19 at 12.07.09.png (892×1 px, 136 KB)

text:

Screenshot 2022-04-19 at 12.10.28.png (876×1 px, 129 KB)

Testing on https://ar.wikipedia.beta.wmflabs.org/wiki/%D9%86%D9%82%D8%A7%D8%B4_%D8%A7%D9%84%D9%85%D8%B3%D8%AA%D8%AE%D8%AF%D9%85:TestEsther?uselang=en with uselang=en

placeholder:

Screenshot 2022-04-19 at 12.15.51.png (890×1 px, 127 KB)

text:

Screenshot 2022-04-19 at 12.17.14.png (950×1 px, 131 KB)

As shown above, arwiki has the placeholder and text right-aligned since we are in the context of a RTL wiki. This behaviour is fixed irrespective of the interface language.

EAkinloose edited projects, added Verified; removed Editing QA.Apr 19 2022, 11:22 AM

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Apr 19 2022, 11:24 AM

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Apr 21 2022, 3:10 PM

ppelberg closed this task as Resolved.Apr 22 2022, 11:47 PM

ppelberg claimed this task.

	F35058043: Screenshot 2022-04-19 at 12.02.02.png
	Apr 19 2022, 11:21 AM

	F35058060: Screenshot 2022-04-19 at 12.10.28.png
	Apr 19 2022, 11:21 AM

	F35058034: Screenshot 2022-04-19 at 11.57.31.png
	Apr 19 2022, 11:21 AM

	F35058055: Screenshot 2022-04-19 at 12.07.09.png
	Apr 19 2022, 11:21 AM

	F35058071: Screenshot 2022-04-19 at 12.15.51.png
	Apr 19 2022, 11:21 AM

	F35058073: Screenshot 2022-04-19 at 12.17.14.png
	Apr 19 2022, 11:21 AM

Placeholder is on wrong side when using different interface direction to contentClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Placeholder is on wrong side when using different interface direction to content
Closed, ResolvedPublic
Actions