| • alexhollender_WMF | |
| Apr 13 2022, 5:08 PM |
| F35061374: Screen Shot 2022-04-21 at 12.50.27 PM.png | |
| Apr 21 2022, 10:50 AM |
| F35056724: Screen Shot 2022-04-18 at 11.32.29 AM.png | |
| Apr 18 2022, 3:34 PM |
| F35053083: Screen Shot 2022-04-15 at 11.11.17 AM.png | |
| Apr 15 2022, 5:18 PM |
| F35051792: Screen Shot 2022-04-14 at 12.58.52 PM.png | |
| Apr 14 2022, 7:59 PM |
| F35050096: image.png | |
| Apr 13 2022, 5:08 PM |
| F35050094: Screen Shot 2022-04-13 at 1.04.07 PM.png | |
| Apr 13 2022, 5:08 PM |
When the browser window is below 720px wide, the Create account button moves to the dropdown menu. There is currently no icon displayed next to it:
Show the userAdd icon from OOUI next to Create account only when it's in the dropdown menu (i.e. not for cases where the browser window is wider than 720px and Create account is shown in the site header).
Change 780865 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/skins/Vector@master] Fix missing create account link icon and ensure icon attributes aren't showing up in rendered HTML
Change 780887 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/core@master] Update create account icon to userAdd
Change 780887 abandoned by Bernard Wang:
[mediawiki/core@master] Update create account icon to userAdd
Reason:
Change 780887 restored by Bernard Wang:
[mediawiki/core@master] Update create account icon to userAdd
Change 780887 merged by jenkins-bot:
[mediawiki/core@master] Update create account icon to userAdd
As part of testing I ran the UI regression suite which flagged this change as expected:
Change 780865 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Fix missing create account link icon and ensure icon attributes aren't showing up in rendered HTML
Was there another change related to this that landed recently? For some reason, the latest visual regression test reports are showing it missing again and Beta also shows the icon missing:
Change 782347 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):
[mediawiki/skins/Vector@master] Fix missing create account link follow up
Change 782347 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Fix missing create account link follow up
@nray i'm seeing it in beta...going to move to signoff but feel free to bring it back if you still have concerns
