Page MenuHomePhabricator

IPInfo word wrapping of source text
Closed, ResolvedPublic2 Estimated Story Points

Description

I'm not sure if this is kind of a bug, but it do cause some strange appearance.
If you enabled IPInfo tools and use Chinese as system language, on my screen text ipinfo-source-geoip2 will looks like this:

image.png (787×466 px, 39 KB)

One character is putted at the next line, which makes the interface look... strange?
Sorry that I don't have any suggestion here (white-space: nowrap; is not a perfect solution), but I thought it should be kind of improved if possible.

AC

  • Make the text left aligned
  • Ensure that the text starts at the same place as the data headings on top

Screen Shot 2022-04-21 at 2.55.00 PM.png (862×840 px, 71 KB)

Event Timeline

Thanks for filing this @Stang

@Prtksxna Do you have any thought on how we could fix this?

Thanks for filing this @Stang

@Prtksxna Do you have any thought on how we could fix this?

Would it help to left-align this text?

AGueyte set the point value for this task to 1.Apr 19 2022, 4:52 PM
Tchanders changed the point value for this task from 1 to 2.Apr 21 2022, 1:24 PM

Testing notes: the feedback button is added by the WikimediaMessages extension. If it is appearing misaligned locally, pull down the latest version of WikimediaMessages.

Change 785969 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/IPInfo@master] Align infobox contents

https://gerrit.wikimedia.org/r/785969

Change 785970 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/WikimediaMessages@master] Align infobox contents

https://gerrit.wikimedia.org/r/785970

Change 785969 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Align infobox contents

https://gerrit.wikimedia.org/r/785969

Change 785970 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Align feedback button added to IPInfo infobox

https://gerrit.wikimedia.org/r/785970

image.png (683×419 px, 39 KB)

Current appearance looks like this :)

Fix screen shots

Screen Shot 2022-04-26 at 4.28.11 PM.png (3,058×1,716 px, 729 KB)

Smaller screen view
Screen Shot 2022-04-26 at 4.27.43 PM.png (2,206×1,736 px, 577 KB)

English language screen view
Screen Shot 2022-04-26 at 4.24.35 PM.png (2,824×1,662 px, 631 KB)