Page MenuHomePhabricator
Create Task
Maniphest T306131

Hard-deprecate RestrictionStore related function in Title class (and remove in 1.41)
Closed, ResolvedPublic
Actions

Description

ReleaseNotes 1.37
* The following methods in the Title class have been deprecated in favor of the
  corresponding methods in the new RestrictionStore service (with different
  names where indicated):
  - ::areCascadeProtectionSourcesLoaded()
  - ::areRestrictionsCascading()
  - ::areRestrictionsLoaded()
  - ::getAllRestrictions()
  - ::getCascadeProtectionSources()
  - ::getFilteredRestrictionTypes()
      -> ::listAllRestrictionTypes()
  - ::getRestrictionExpiry()
  - ::getRestrictionTypes()
      -> ::listApplicableRestrictionTypes()
  - ::getRestrictions()
  - ::isCascadeProtected()
  - ::isProtected()
  - ::isSemiProtected()
  - ::loadRestrictionsFromRows()

All should be replaced, hard-deprecated and removed

basic codesearch:
https://codesearch.wmcloud.org/search/?q=(%3A%3A%7C-%3E)%5Cs*(areCascadeProtectionSourcesLoaded%7CareRestrictionsCascading%7CareRestrictionsLoaded%7CgetAllRestrictions%7CgetCascadeProtectionSources%7CgetFilteredRestrictionTypes%7CgetRestrictionExpiry%7CgetRestrictionTypes%7CgetRestrictions%7CisCascadeProtected%7CisProtected%7CisSemiProtected|loadRestrictionsFromRows)%5Cb&i=nope&files=&excludeFiles=&repos=

Special case: Title::loadRestrictions
https://codesearch.wmcloud.org/search/?q=(%3A%3A%7C-%3E)%5Cs*loadRestrictions%5Cb&i=nope&files=&excludeFiles=&repos=

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
title: Remove protection related deprecated Title functionsmediawiki/coremaster+20 -619
Hard-deprecate protection related deprecated Title functionmediawiki/coremaster+55 -13
tests: Remove mocking of deprecated Title::getRestrictionsmediawiki/extensions/Wikibasemaster+0 -4
Remove usage of protection related deprecated Title functionmediawiki/extensions/WikibaseMediaInfomaster+153 -171
wikipage: Remove usage of protection related deprecated Title functionmediawiki/coremaster+12 -10
Remove usage of protection related deprecated Title functionmediawiki/extensions/GrowthExperimentsmaster+51 -15
PermissionManager: Remove usage of protection related Title functionmediawiki/coremaster+41 -15
Remove usage of protection related deprecated Title functionmediawiki/coremaster+57 -26
Remove usage of protection related deprecated Title functionmediawiki/extensions/MobileFrontendmaster+4 -2
Remove usage of protection related deprecated Title functionmediawiki/extensions/MachineVisionmaster+9 -1
Remove usage of protection related deprecated Title functionmediawiki/extensions/FileImportermaster+73 -18
Remove usage of protection related deprecated Title functionmediawiki/extensions/VisualEditormaster+14 -6
Remove usage of protection related deprecated Title functionmediawiki/extensions/MassMessagemaster+14 -4
Remove usage of protection related deprecated Title functionmediawiki/extensions/LiquidThreadsmaster+8 -5
Remove usage of protection related deprecated Title functionmediawiki/extensions/FlaggedRevsmaster+10 -7
Remove usage of protection related deprecated Title functionmediawiki/skins/Nostalgiamaster+6 -3
Remove usage of protection related deprecated Title functionmediawiki/extensions/DynamicPageListmaster+3 -2
Remove usage of protection related deprecated Title functionmediawiki/extensions/AuthorProtectmaster+40 -10
Remove usage of protection related deprecated Title functionmediawiki/extensions/DrawioEditormaster+9 -1
Remove usage of protection related deprecated Title functionmediawiki/extensions/RightFunctionsmaster+31 -11
Remove usage of protection related deprecated Title functionmediawiki/extensions/UserProtectmaster+6 -3
Remove usage of protection related deprecated Title functionmediawiki/extensions/ProtectionIndicatormaster+25 -8
action: Remove usage of protection related deprecated Title functionmediawiki/coremaster+29 -12
ProtectionForm: Remove usage of deprecated Title functionmediawiki/coremaster+19 -8
Remove usages of deprecated Title::getRestrictionTypesmediawiki/coremaster+28 -10
Show related patches Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Apr 13 2022, 8:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2022, 8:03 PM
gerritbot added a comment.Apr 13 2022, 8:08 PM

Change 779937 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Remove usages of deprecated Title::getRestrictionTypes

https://gerrit.wikimedia.org/r/779937

gerritbot added a project: Patch-For-Review.Apr 13 2022, 8:09 PM
Umherirrender updated the task description. (Show Details)Apr 13 2022, 8:19 PM
gerritbot added a comment.Apr 13 2022, 8:44 PM

Change 779938 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] action: Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/779938

Umherirrender updated the task description. (Show Details)Apr 13 2022, 8:48 PM
gerritbot added a comment.Apr 13 2022, 8:54 PM

Change 779942 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] ProtectionForm: Remove usage of deprecated Title function

https://gerrit.wikimedia.org/r/779942

gerritbot added a comment.Apr 13 2022, 8:58 PM

Change 779943 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] wikipage: Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/779943

gerritbot added a comment.Apr 14 2022, 5:14 AM

Change 779942 merged by jenkins-bot:

[mediawiki/core@master] ProtectionForm: Remove usage of deprecated Title function

https://gerrit.wikimedia.org/r/779942

gerritbot added a comment.Apr 14 2022, 5:15 AM

Change 779937 merged by jenkins-bot:

[mediawiki/core@master] Remove usages of deprecated Title::getRestrictionTypes

https://gerrit.wikimedia.org/r/779937

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.8; 2022-04-18).Apr 14 2022, 6:00 AM
gerritbot added a comment.Apr 14 2022, 3:02 PM

Change 779938 merged by jenkins-bot:

[mediawiki/core@master] action: Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/779938

gerritbot added a comment.Apr 14 2022, 4:40 PM

Change 780897 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] PermissionManager: Remove usage of protection related Title function

https://gerrit.wikimedia.org/r/780897

Umherirrender updated the task description. (Show Details)Apr 14 2022, 4:46 PM
gerritbot added a comment.Apr 14 2022, 5:14 PM

Change 780908 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/780908

gerritbot added a comment.Apr 14 2022, 6:55 PM

Change 780975 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/DynamicPageList@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/780975

gerritbot added a comment.Apr 14 2022, 7:09 PM

Change 780981 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/FileImporter@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/780981

gerritbot added a comment.Apr 14 2022, 7:20 PM

Change 780989 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/DrawioEditor@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/780989

gerritbot added a comment.Apr 14 2022, 7:28 PM

Change 780991 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AuthorProtect@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/780991

gerritbot added a comment.Apr 14 2022, 7:32 PM

Change 780997 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/skins/Nostalgia@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/780997

gerritbot added a comment.Apr 14 2022, 7:41 PM

Change 781008 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MachineVision@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/781008

gerritbot added a comment.Apr 14 2022, 7:44 PM

Change 781010 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MassMessage@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/781010

gerritbot added a comment.Apr 14 2022, 7:49 PM

Change 781011 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/FlaggedRevs@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/781011

gerritbot added a comment.Apr 14 2022, 7:53 PM

Change 781014 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/LiquidThreads@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/781014

gerritbot added a comment.Apr 14 2022, 7:55 PM

Change 781015 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MobileFrontend@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/781015

gerritbot added a comment.Apr 14 2022, 8:02 PM

Change 781016 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikibaseMediaInfo@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/781016

gerritbot added a comment.Apr 14 2022, 8:06 PM

Change 781018 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/VisualEditor@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/781018

gerritbot added a comment.Apr 14 2022, 8:08 PM

Change 781019 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/UserProtect@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/781019

gerritbot added a comment.Apr 14 2022, 8:10 PM

Change 781020 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/RightFunctions@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/781020

gerritbot added a comment.Apr 14 2022, 8:17 PM

Change 781021 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ProtectionIndicator@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/781021

gerritbot added a comment.Apr 14 2022, 8:44 PM

Change 781038 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GrowthExperiments@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/781038

gerritbot added a comment.Apr 14 2022, 9:31 PM

Change 781015 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/781015

gerritbot added a comment.Apr 14 2022, 9:31 PM

Change 781011 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/781011

gerritbot added a comment.Apr 14 2022, 9:31 PM

Change 781010 merged by jenkins-bot:

[mediawiki/extensions/MassMessage@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/781010

gerritbot added a comment.Apr 14 2022, 9:31 PM

Change 781014 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/781014

gerritbot added a comment.Apr 14 2022, 9:38 PM

Change 780981 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/780981

gerritbot added a comment.Apr 14 2022, 9:38 PM

Change 780997 merged by jenkins-bot:

[mediawiki/skins/Nostalgia@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/780997

gerritbot added a comment.Apr 14 2022, 9:39 PM

Change 781018 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/781018

gerritbot added a comment.Apr 14 2022, 9:41 PM

Change 781008 merged by jenkins-bot:

[mediawiki/extensions/MachineVision@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/781008

gerritbot added a comment.Apr 14 2022, 9:43 PM

Change 781021 merged by jenkins-bot:

[mediawiki/extensions/ProtectionIndicator@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/781021

Umherirrender mentioned this in rEPRIc1418eb7efd6: Remove usage of protection related deprecated Title function.Apr 14 2022, 9:44 PM
gerritbot added a comment.Apr 14 2022, 9:52 PM

Change 781019 merged by jenkins-bot:

[mediawiki/extensions/UserProtect@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/781019

gerritbot added a comment.Apr 14 2022, 9:52 PM

Change 781020 merged by jenkins-bot:

[mediawiki/extensions/RightFunctions@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/781020

gerritbot added a comment.Apr 14 2022, 9:52 PM

Change 780989 merged by jenkins-bot:

[mediawiki/extensions/DrawioEditor@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/780989

gerritbot added a comment.Apr 14 2022, 9:52 PM

Change 780991 merged by jenkins-bot:

[mediawiki/extensions/AuthorProtect@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/780991

gerritbot added a comment.Apr 14 2022, 9:52 PM

Change 780975 merged by jenkins-bot:

[mediawiki/extensions/DynamicPageList@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/780975

Umherirrender mentioned this in rEDIOeeecd5bac788: Remove usage of protection related deprecated Title function.Apr 14 2022, 9:52 PM
Umherirrender mentioned this in rEUSP8f74c7104896: Remove usage of protection related deprecated Title function.
gerritbot added a comment.Apr 14 2022, 10:08 PM

Change 780908 merged by jenkins-bot:

[mediawiki/core@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/780908

gerritbot added a comment.Apr 14 2022, 10:31 PM

Change 780897 merged by jenkins-bot:

[mediawiki/core@master] PermissionManager: Remove usage of protection related Title function

https://gerrit.wikimedia.org/r/780897

gerritbot added a comment.Apr 15 2022, 3:51 AM

Change 781038 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/781038

gerritbot added a comment.May 15 2022, 8:52 AM

Change 779943 merged by jenkins-bot:

[mediawiki/core@master] wikipage: Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/779943

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.12; 2022-05-16); removed MW-1.39-notes (1.39.0-wmf.8; 2022-04-18).May 15 2022, 10:00 AM
gerritbot added a comment.Jul 8 2022, 3:31 PM

Change 781016 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Remove usage of protection related deprecated Title function

https://gerrit.wikimedia.org/r/781016

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.21; 2022-07-18); removed MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).Jul 12 2022, 6:02 AM
gerritbot added a comment.Sep 23 2022, 8:09 PM

Change 834611 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Hard-deprecate protection related deprecated Title function

https://gerrit.wikimedia.org/r/834611

Umherirrender claimed this task.Sep 23 2022, 8:54 PM
Umherirrender triaged this task as Low priority.
gerritbot added a comment.Dec 15 2022, 11:45 PM

Change 868478 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] tests: Remove mocking of deprecated Title::getRestrictions

https://gerrit.wikimedia.org/r/868478

gerritbot added a comment.Dec 16 2022, 12:36 AM

Change 868478 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] tests: Remove mocking of deprecated Title::getRestrictions

https://gerrit.wikimedia.org/r/868478

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 16 2022, 1:01 AM
gerritbot added a comment.Dec 16 2022, 1:22 AM

Change 834611 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate protection related deprecated Title function

https://gerrit.wikimedia.org/r/834611

Umherirrender renamed this task from Hard-deprecate RestrictionStore related function in Title class (and remove a release later) to Hard-deprecate RestrictionStore related function in Title class (and remove in 1.41).Dec 16 2022, 1:24 AM
Umherirrender changed the task status from Open to Stalled.
Umherirrender removed Umherirrender as the assignee of this task.
Umherirrender removed a project: Patch-For-Review.
Umherirrender moved this task from Untriaged to 2021 | MW 1.36 / 1.37 on the Technical-Debt (Deprecation process) board.Dec 16 2022, 11:08 PM
Umherirrender changed the task status from Stalled to Open.Mar 14 2023, 9:35 PM
gerritbot added a comment.May 9 2023, 7:15 PM

Change 917937 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] title: Remove protection related deprecated Title functions

https://gerrit.wikimedia.org/r/917937

gerritbot added a project: Patch-For-Review.May 9 2023, 7:15 PM
gerritbot added a comment.May 9 2023, 10:56 PM

Change 917937 merged by jenkins-bot:

[mediawiki/core@master] title: Remove protection related deprecated Title functions

https://gerrit.wikimedia.org/r/917937

Maintenance_bot removed a project: Patch-For-Review.May 9 2023, 11:10 PM
Umherirrender closed this task as Resolved.May 10 2023, 7:28 PM
Umherirrender claimed this task.
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 5:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits