Page MenuHomePhabricator
Create Task
Maniphest T306137

Reply tool interface looks messed up when replying to a bullet list while using different interface direction to content
Closed, ResolvedPublic
Actions

Assigned To
matmarex
Authored By
matmarex
Apr 13 2022, 9:38 PM
Tags
Referenced Files
F35050287: image.png
Apr 13 2022, 9:38 PM
F35050300: image.png
Apr 13 2022, 9:38 PM
F35050289: image.png
Apr 13 2022, 9:38 PM
F35050302: image.png
Apr 13 2022, 9:38 PM
Subscribers
Aklapper
matmarex

Description

While testing T306040, I noticed a different kind of glitch for some comments. It turns out that it occurs when the reply is indented inside a bulleted or numbered list (<li>), and it is caused by a default browser stylesheet setting li { text-align: match-parent; }, in Chrome and Firefox. I'm not sure what is the purpose of that rule, nor why it is only applied to li.

For example:

Incorrecthttps://ar.wikipedia.org/wiki/ويكيبيديا:الميدان/تقنية/2020/يناير?uselang=en#c-صالح-2020-01-23T16:59:00.000Z-Wisam85-2020-01-23T16:56:00.000Z
image.png (2×3 px, 519 KB)
Correcthttps://ar.wikipedia.org/wiki/ويكيبيديا:الميدان/تقنية/2020/يناير?uselang=en#c-Wisam85-2020-01-23T17:01:00.000Z-Wisam85-2020-01-23T16:56:00.000Z
image.png (2×3 px, 520 KB)
Incorrecthttps://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)/Archive_184?uselang=ar#c-Steel1943-2020-09-03T19:15:00.000Z-Johnuniq-2020-09-03T03:07:00.000Z
image.png (2×3 px, 588 KB)
Correcthttps://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)/Archive_184?uselang=ar#c-Xaosflux-2020-09-04T00:05:00.000Z-Johnuniq-2020-09-03T03:07:00.000Z
image.png (2×3 px, 355 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ReplyWidget: Fix text-align when content and user language have different directionmediawiki/extensions/DiscussionToolsmaster+5 -0
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Apr 13 2022, 9:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2022, 9:39 PM
gerritbot added a comment.Apr 19 2022, 8:06 PM

Change 784316 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] ReplyWidget: Fix text-align when content and user language have different direction

https://gerrit.wikimedia.org/r/784316

gerritbot added a project: Patch-For-Review.Apr 19 2022, 8:06 PM
matmarex claimed this task.Apr 19 2022, 8:06 PM
matmarex added a project: Editing-team (Kanban Board).
matmarex moved this task from Backlog to Triaged on the DiscussionTools board.
matmarex moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.Apr 21 2022, 1:00 AM

Change 784316 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] ReplyWidget: Fix text-align when content and user language have different direction

https://gerrit.wikimedia.org/r/784316

Maintenance_bot removed a project: Patch-For-Review.Apr 21 2022, 1:30 AM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Apr 21 2022, 1:48 AM
matmarex added a project: Editing QA.
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.9; 2022-04-25).Apr 21 2022, 2:00 AM
EAkinloose edited projects, added Verified; removed Editing QA.Apr 25 2022, 11:33 PM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Apr 26 2022, 11:50 PM
ppelberg closed this task as Resolved.May 7 2022, 1:03 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits