Make flaggedpage_config.fpc_select nullable on wmf wikis
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Zabe
	Apr 13 2022, 11:40 PM

Description

ALTERs to run: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/779566/4/backend/schema/mysql/patch-nullable-fpc_select.sql
Where to run those changes: flaggedrevs.dblist
When to run those changes: When DBA has time.
If the schema change is backwards compatible: Yes.
If the schema change has been tested already on some of the test/beta wikis: beta cluster runs with the new schema
if the data should be made available on the labs replicas and/or dumps: No change to current rules required.

As far as I know the table is tiny or empty on all flaggedrevs wikis.

Related Objects
Search...

Status	Assigned	Task
Open	None	T31744 FlaggedRev installation requests (tracking)
Stalled	None	T143886 Activating Flagged revisions on ar.wikinews
Stalled	None	T204354 Flagged Revisions for Vietnamese Wikipedia
Stalled	None	T205145 Deploy FlaggedRevs on bn.wikibooks
Stalled	None	T221933 Enable Flagged Revisions (for trial run purpose) at the Chinese Wikipedia
Open	None	T185664 Code stewardship review: FlaggedRevs
Open	Ladsgroup	T277883 Drop all low-use and unused features of FlaggedRevs to make it more maintainable
Resolved	Zabe	T262978 flaggedpage_config.fpc_select is unused
Resolved	Ladsgroup	T306147 Make flaggedpage_config.fpc_select nullable on wmf wikis

Event Timeline

Zabe created this task.Apr 13 2022, 11:40 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2022, 11:40 PM

Zabe added a parent task: T262978: flaggedpage_config.fpc_select is unused.Apr 13 2022, 11:40 PM

We probably can run this on master and let it propagate:

ladsgroup@mwmaint1002:~$ expanddblist flaggedrevs | xargs -I {} sql {} -- -e "select count(*) from flaggedpage_config;"
count(*)
1
count(*)
0
count(*)
8
count(*)
340
count(*)
1
count(*)
17
count(*)
0
count(*)
46
count(*)
2
count(*)
0
count(*)
0
count(*)
0
count(*)
4313
count(*)
2785
count(*)
2
count(*)
0
count(*)
0
count(*)
988
count(*)
0
count(*)
109
count(*)
9
count(*)
6
count(*)
247
count(*)
13
count(*)
0
count(*)
163
count(*)
0
count(*)
0
count(*)
0
count(*)
0
count(*)
0
count(*)
0
count(*)
0
count(*)
14
count(*)
2343
count(*)
0
count(*)
10645
count(*)
0
count(*)
0
count(*)
14
count(*)
0
count(*)
0
count(*)
0
count(*)
5
count(*)
0
count(*)
0
count(*)
499
count(*)
0
count(*)
0
count(*)
0

In one wiki it's 10K rows but the rest it's pretty small. 10K is not that big either.

Ladsgroup claimed this task.Apr 18 2022, 3:12 PM

Ladsgroup moved this task from Triage to Ready on the DBA board.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptApr 18 2022, 3:12 PM

Ladsgroup closed this task as Resolved.Apr 18 2022, 4:41 PM

Ladsgroup moved this task from Ready to Done on the DBA board.

Maintenance_bot moved this task from Incoming to Done on the User-Ladsgroup board.Apr 18 2022, 5:29 PM

Make flaggedpage_config.fpc_select nullable on wmf wikisClosed, ResolvedPublicActions

Description

Related ObjectsSearch...

Event Timeline

Make flaggedpage_config.fpc_select nullable on wmf wikis
Closed, ResolvedPublic
Actions

Related Objects
Search...