Page MenuHomePhabricator
Create Task
Maniphest T306164

fetchZkeys resolve the incorrect promise
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • go to http://localhost:8080/wiki/Special:CreateZObject?zid=Z14&Z14K1=Z10030&view=zobject-editor

What happens?:

  • the implementation loaded does not always have the function pre-loaded

What should have happened instead?:

  • the function should always be pre-set
NOTE: the fetchZKeys is resolving all the promises in the loop therefore returning the promise too early.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix multiple promises issuemediawiki/extensions/WikiLambdamaster+24 -16
fetchZkeys resolve the incorrect promisemediawiki/extensions/WikiLambdamaster+39 -12
Customize query in gerrit

Event Timeline

SimoneThisDot created this task.Apr 14 2022, 8:12 AM
SimoneThisDot changed the task status from Open to In Progress.
SimoneThisDot claimed this task.
SimoneThisDot moved this task from To Triage to Phase θ – Throttling on the Abstract Wikipedia team board.
SimoneThisDot edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
SimoneThisDot moved this task from Incoming to Ready: G10. Function calls UX on the Abstract Wikipedia team (Phase θ – Throttling) board.
gerritbot added a comment.Apr 14 2022, 1:46 PM

Change 780809 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/WikiLambda@master] fetchZkeys resolve the incorrect promise

https://gerrit.wikimedia.org/r/780809

gerritbot added a project: Patch-For-Review.Apr 14 2022, 1:46 PM
gerritbot added a comment.Apr 19 2022, 1:02 PM

Change 780809 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] fetchZkeys resolve the incorrect promise

https://gerrit.wikimedia.org/r/780809

Maintenance_bot removed a project: Patch-For-Review.Apr 19 2022, 1:31 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.9; 2022-04-25).Apr 19 2022, 2:00 PM
Jdforrester-WMF moved this task from Ready: G10. Function calls UX to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.Apr 19 2022, 4:25 PM
Jdforrester-WMF closed this task as Resolved.Apr 19 2022, 4:58 PM
gerritbot added a comment.Apr 20 2022, 7:42 PM

Change 784757 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/WikiLambda@master] Fix multiple promises issue

https://gerrit.wikimedia.org/r/784757

gerritbot added a project: Patch-For-Review.Apr 20 2022, 7:42 PM
gerritbot added a comment.Apr 22 2022, 9:51 AM

Change 784757 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix multiple promises issue

https://gerrit.wikimedia.org/r/784757

Maintenance_bot removed a project: Patch-For-Review.Apr 22 2022, 10:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits