Page MenuHomePhabricator
Create Task
Maniphest T306184

OATHAuth's disableOATHAuthForUser.php script triggers a Notification that can't be sent as MW isn't initialised yet, so causes a production error
Closed, DuplicatePublicPRODUCTION ERROR
Actions

Description

Running the script works, but errors:

mwscript extensions/OATHAuth/maintenance/disableOATHAuthForUser.php --wiki=labswiki <x>
LogicException from line 408 of /srv/mediawiki/php-1.39.0-wmf.7/includes/cache/MessageCache.php: Process cache for 'en' should be set by now.
#0 /srv/mediawiki/php-1.39.0-wmf.7/includes/cache/MessageCache.php(1113): MessageCache->load('en')
#1 /srv/mediawiki/php-1.39.0-wmf.7/includes/cache/MessageCache.php(1041): MessageCache->getMsgFromNamespace('Emailsender', 'en')
#2 /srv/mediawiki/php-1.39.0-wmf.7/includes/cache/MessageCache.php(1011): MessageCache->getMessageForLang(Object(LanguageEn), 'emailsender', true, Array)
#3 /srv/mediawiki/php-1.39.0-wmf.7/includes/cache/MessageCache.php(953): MessageCache->getMessageFromFallbackChain(Object(LanguageEn), 'emailsender', true)
#4 /srv/mediawiki/php-1.39.0-wmf.7/includes/language/Message.php(1491): MessageCache->get('emailsender', true, Object(LanguageEn))
#5 /srv/mediawiki/php-1.39.0-wmf.7/includes/language/Message.php(968): Message->fetchMessage()
#6 /srv/mediawiki/php-1.39.0-wmf.7/includes/language/Message.php(1071): Message->format('text')
#7 /srv/mediawiki/php-1.39.0-wmf.7/extensions/Echo/includes/Notifier.php(94): Message->text()
#8 /srv/mediawiki/php-1.39.0-wmf.7/extensions/Echo/includes/controller/NotificationController.php(424): EchoNotifier::notifyWithEmail(Object(User), Object(EchoEvent))
#9 /srv/mediawiki/php-1.39.0-wmf.7/extensions/Echo/includes/controller/NotificationController.php(132): EchoNotificationController::doNotification(Object(EchoEvent), Object(User), 'email')
#10 /srv/mediawiki/php-1.39.0-wmf.7/extensions/Echo/includes/model/Event.php(195): EchoNotificationController::notify(Object(EchoEvent), false)
#11 /srv/mediawiki/php-1.39.0-wmf.7/extensions/OATHAuth/src/Notifications/Manager.php(56): EchoEvent::create(Array)
#12 /srv/mediawiki/php-1.39.0-wmf.7/extensions/OATHAuth/src/OATHUserRepository.php(182): MediaWiki\Extension\OATHAuth\Notifications\Manager::notifyDisabled(Object(MediaWiki\Extension\OATHAuth\OATHUser), false)
#13 /srv/mediawiki/php-1.39.0-wmf.7/extensions/OATHAuth/maintenance/disableOATHAuthForUser.php(37): MediaWiki\Extension\OATHAuth\OATHUserRepository->remove(Object(MediaWiki\Extension\OATHAuth\OATHUser), 'Maintenance scr...', false)
#14 /srv/mediawiki/php-1.39.0-wmf.7/maintenance/doMaintenance.php(114): DisableOATHAuthForUser->execute()
#15 /srv/mediawiki/php-1.39.0-wmf.7/extensions/OATHAuth/maintenance/disableOATHAuthForUser.php(48): require_once('/srv/mediawiki/...')
#16 /srv/mediawiki/multiversion/MWScript.php(116): require_once('/srv/mediawiki/...')
#17 {main}
jforrester@mwmaint1002:~$ mwscript extensions/OATHAuth/maintenance/disableOATHAuthForUser.php --wiki=labswiki <x>
User AAssaf doesn't have OATHAuth enabled!

Presumably the notifications / e-mails aren't sent?

Caused by T210075: Send notification when 2FA is disabled / T210963: Send an email when 2FA is disabled work, but I don't think it's serious enough to revert.

Related Objects

Event Timeline

Jdforrester-WMF created this task.Apr 14 2022, 1:43 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 14 2022, 1:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Zabe subscribed.Apr 14 2022, 1:50 PM
Krinkle subscribed.Apr 14 2022, 3:14 PM

Does the error also happen when the script is run from a labweb host?

Ref T237773#7841755 and (now written) wikitech:Maintenance server.

Krinkle moved this task from Untriaged to Apr 2022 on the Wikimedia-production-error board.Apr 14 2022, 3:14 PM
Jdforrester-WMF added a comment.Apr 14 2022, 5:56 PM
In T306184#7855436, @Krinkle wrote:

Does the error also happen when the script is run from a labweb host?

Ref T237773#7841755 and (now written) wikitech:Maintenance server.

Not sure; I was following the instructions which suggested it'd be fine from mwscript*. I don't hugely want to faff around resetting my 2FA status on a real account.

Krinkle added a comment.Apr 14 2022, 6:15 PM
In T306184#7856070, @Jdforrester-WMF wrote:
In T306184#7855436, @Krinkle wrote:

Does the error also happen when the script is run from a labweb host?

Ref T237773#7841755 and (now written) wikitech:Maintenance server.

Not sure; I was following the instructions which suggested it'd be fine from mwscript*. I don't hugely want to faff around resetting my 2FA status on a real account.

The instructions had an if/else branch, but the section for the disableOATHAuthForUser script specifically said "if wiktech then on a labsweb host or mwmaint1002". I've removed the "or" clause as this clearly doesn't work.

Jdforrester-WMF added a comment.Apr 14 2022, 7:26 PM
In T306184#7856133, @Krinkle wrote:
In T306184#7856070, @Jdforrester-WMF wrote:
In T306184#7855436, @Krinkle wrote:

Does the error also happen when the script is run from a labweb host?

Ref T237773#7841755 and (now written) wikitech:Maintenance server.

Not sure; I was following the instructions which suggested it'd be fine from mwscript*. I don't hugely want to faff around resetting my 2FA status on a real account.

The instructions had an if/else branch, but the section for the disableOATHAuthForUser script specifically said "if wiktech then on a labsweb host or mwmaint1002". I've removed the "or" clause as this clearly doesn't work.

That's not true, it worked fine, it just emitted a fatal error as it happened because of a novel code path.

• mewoph moved this task from Inbox to Needs Discussion on the Growth-Team board.Apr 20 2022, 9:09 PM
Tgr removed projects: Growth-Team, Notifications (Echo).May 27 2022, 6:17 PM
Tgr subscribed.

How can MediaWiki not be initialized by the time Maintenance::execute() is called? That sounds like some kind of serious Wikitech configuration bug.

In any case, not really related to Notifications.

Reedy added a project: TestMe.Dec 6 2023, 12:49 PM
Reedy moved this task from Backlog to Bugs on the MediaWiki-extensions-OATHAuth board.Mar 29 2024, 4:44 PM
Reedy added a project: wikitech.wikimedia.org.
Krinkle mentioned this in T371199: Installer sets a $wgSQLiteDataDir to a relative path, causing DB access exceptions when running maintenance scripts from any directory other than MediaWiki root ($IP).Jul 28 2024, 8:44 PM
matmarex subscribed.Mar 18 2025, 1:24 AM

I will hazard a guess that this was the same problem as T359823, triggered by Memcached being inaccessible (maybe it was a transient issue, or maybe it was misconfigured for Wikitech wiki in 2022).

I don't think anyone is going to look into this specific issue anyway, since it happened 3 years ago.

Restricted Application changed the subtype of this task from "Task" to "Production Error". · View Herald TranscriptMar 18 2025, 1:24 AM
matmarex closed this task as a duplicate of T359823: LogicException: Process cache for 'en' should be set by now.Mar 18 2025, 1:24 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits