When adding statements, some items won't resolve to their labels after being selected, display QNumber instead.
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Moebeus
	Apr 14 2022, 7:29 PM

Description

Problem:
Since 2022-04-07, when selecting some Item values in statements on Wikidata, the ID instead of the lable is shown after selecting the Item value.

Screenshots/mockups:

Start a statement

Select an item

QNumber displays instead of label

After save we see the label as expected.

Acceptance criteria:

Labels for values are shown when an Item value is selected in a statement

Note:

Nikki has an idea about what is wrong in T306214#7856786
It is now happening for every Property. It might be restricted to Properties that have value suggestions like P21.

Details

	Subject	Repo	Branch	Lines +/-
	Use new display part in entity selector some more	mediawiki/extensions/Wikibase	master	+15 -1

Customize query in gerrit

Related Objects

Mentioned Here: P21 bla.yaml

Event Timeline

Moebeus created this task.Apr 14 2022, 7:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 14 2022, 7:29 PM

Tagging WBQC if this is specific to the suggestions feature.

LucasWerkmeister unsubscribed.Apr 14 2022, 7:39 PM

Nikki subscribed.Apr 14 2022, 8:32 PM

Select the property P21 and it will show you a list of suggestions.
Press the down arrow to go through the suggestions and it will show the ID in the input field for each one.
Type "male" and it will do a search.
Press the down arrow to go through the suggestions again and it will show the ID for the ones that were already shown before (loaded from the suggestions) and the label for the ones that weren't (loaded from the search).

It seems like this function is the problem? https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/master/view/resources/jquery/wikibase/jquery.wikibase.entityselector.js#531
It only checks entityStub.label. The search results have entityStub.label and entityStub.display.label so it works fine, but the suggestions only have entityStub.display.label which makes it fall back to the ID.

@Manuel this seems pretty meh

Manuel moved this task from Incoming to Prioritized Backlog on the Wikidata-Campsite (Team A Hearth 🏰🔥) board.Apr 19 2022, 7:56 AM

Change 784237 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use new display part in entity selector some more

https://gerrit.wikimedia.org/r/784237

gerritbot added a project: Patch-For-Review.Apr 19 2022, 11:16 AM

Lucas_Werkmeister_WMDE claimed this task.Apr 19 2022, 11:16 AM

Lucas_Werkmeister_WMDE moved this task from Prioritized Backlog to Peer Review on the Wikidata-Campsite (Team A Hearth 🏰🔥) board.

hoo moved this task from Peer Review to Product Verification on the Wikidata-Campsite (Team A Hearth 🏰🔥) board.Jun 9 2022, 11:49 PM

Change 784237 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use new display part in entity selector some more

https://gerrit.wikimedia.org/r/784237

Maintenance_bot removed a project: Patch-For-Review.Jun 10 2022, 12:30 AM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.16; 2022-06-13).Jun 10 2022, 1:00 AM

Seems to be resolved now, following the reproduction steps in the task description.

When adding statements, some items won't resolve to their labels after being selected, display QNumber instead.Closed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

When adding statements, some items won't resolve to their labels after being selected, display QNumber instead.
Closed, ResolvedPublicBUG REPORT
Actions